Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16598

Enable zookeeper useMulti always and clean up in HBase code

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      Deprecate the configuration property 'hbase.zookeeper.useMulti'.
      useMulti will always be enabled. ZooKeeper 3.4.x and newer is required.

      Internal:

      The ZKUtil#multiOrSequential(ZooKeeperWatcher zkw, List<ZKUtilOp> ops, boolean runSequentialOnMultiFailure) will not check 'hbase.zookeeper.useMulti' anymore, and will always use multi.
      It can still fall back to sequential operations if:

      RunSequentialOnMultiFailure is true
      On calling multi, we get a ZooKeeper exception that can be handled by a sequential call.
      Show
      Deprecate the configuration property 'hbase.zookeeper.useMulti'. useMulti will always be enabled. ZooKeeper 3.4.x and newer is required. Internal: The ZKUtil#multiOrSequential(ZooKeeperWatcher zkw, List<ZKUtilOp> ops, boolean runSequentialOnMultiFailure) will not check 'hbase.zookeeper.useMulti' anymore, and will always use multi. It can still fall back to sequential operations if: RunSequentialOnMultiFailure is true On calling multi, we get a ZooKeeper exception that can be handled by a sequential call.

      Description

      We have zookeeper useMulti default true since HBase 1.0.0
      And in our Doc, "ZooKeeper 3.4.x is required as of HBase 1.0.0"
      The benefit of useMulti is obvious.
      Let's clean up the code to remove useMulti false case so that we don't have to continue with the hassle of maintaining two version of the code (e.g. in replication) . No go back to pre 3.4.x Zookeeper.

        Attachments

        1. HBASE-16598-v5.patch
          62 kB
          Jerry He
        2. HBASE-16598-v4.patch
          62 kB
          Jerry He
        3. HBASE-16598-v3.patch
          62 kB
          Jerry He
        4. HBASE-16598-v2.patch
          55 kB
          Jerry He
        5. HBASE-16598.patch
          53 kB
          Jerry He

          Activity

            People

            • Assignee:
              jinghe Jerry He
              Reporter:
              jinghe Jerry He
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: