[HBASE-16471] Region Server metrics context will be wrong when machine hostname contain "master" word

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.0, 0.98.21, 2.0.0
• Fix Version/s: 1.3.0, 1.1.6, 1.2.3, 0.98.22, 2.0.0
• Component/s: metrics
• Hadoop Flags: Reviewed
• Assignee: Pankaj Kumar
• Reporter: Pankaj Kumar
• Created: 23/Aug/16 04:09
• Updated: 09/Nov/17 01:28
• Resolved: 24/Aug/16 13:42

Description

While initializing RSRpcServices server name is formed as,

    String name = rs.getProcessName() + "/" + initialIsa.toString();

So name will be like "regionserver/host_Name/host_IP:port".

During MetricsHBaseServer intializing, we create server context name using String contains() which will be wrong when machine hostname contain "master" words.
In MetricsHBaseServerSourceFactory,

  protected static String createContextName(String serverName) {
    if (serverName.contains("HMaster") || serverName.contains("master")) {
      return "Master";
    } else if (serverName.contains("HRegion") || serverName.contains("regionserver")) {
      return "RegionServer";
    }
    return "IPC";
  }

For example, "regionserver/node-master1-xyz/host-IP:16020"