Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16460

Can't rebuild the BucketAllocator's data structures when BucketCache uses FileIOEngine

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1.6, 1.3.1, 1.2.3, 0.98.22, 2.0.0
    • 1.3.0, 1.1.7, 1.2.4, 2.0.0
    • BucketCache
    • None
    • Reviewed

    Description

      When bucket cache use FileIOEngine, it will rebuild the bucket allocator's data structures from a persisted map. So it should first read the map from persistence file then use the map to new a BucketAllocator. But now the code has wrong sequence in retrieveFromFile() method of BucketCache.java.

            BucketAllocator allocator = new BucketAllocator(cacheCapacity, bucketSizes, backingMap, realCacheSize);
            backingMap = (ConcurrentHashMap<BlockCacheKey, BucketEntry>) ois.readObject();
      

      Attachments

        1. HBASE-16460-branch-1-v6.patch
          9 kB
          Guanghao Zhang
        2. 16460.v6.patch
          10 kB
          Guanghao Zhang
        3. 16460.v6.patch
          10 kB
          Ted Yu
        4. HBASE-16460-v5.patch
          10 kB
          Guanghao Zhang
        5. HBASE-16460-v5.patch
          10 kB
          Guanghao Zhang
        6. HBASE-16460-v4.patch
          9 kB
          Guanghao Zhang
        7. HBASE-16460-v3.patch
          9 kB
          Guanghao Zhang
        8. HBASE-16460-v2.patch
          10 kB
          Guanghao Zhang
        9. HBASE-16460-v2.patch
          10 kB
          Guanghao Zhang
        10. HBASE-16460-v1.patch
          6 kB
          Guanghao Zhang
        11. HBASE-16460.patch
          5 kB
          Guanghao Zhang

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            zghao Guanghao Zhang
            zghao Guanghao Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment