[HBASE-16456] Fix findbugs warnings in hbase-rsgroup module

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Guangxu Cheng
• Reporter: Ted Yu
• Created: 19/Aug/16 16:34
• Updated: 06/Jul/17 01:43
• Resolved: 24/Aug/16 09:30

Description

https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html :

Multithreaded correctness Warnings

Code Warning
SC new org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) invokes org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start()
SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, String) calls Thread.sleep() with a lock held
Performance Warnings

Code Warning
WMI org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) makes inefficient use of keySet iterator instead of entrySet iterator
WMI org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) makes inefficient use of keySet iterator instead of entrySet iterator
Dodgy code Warnings

Code Warning
REC Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline()
ST Write to static field org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from instance method org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment)

Issue Links

• is related to: HBASE-15631 Backport Regionserver Groups (HBASE-6721) to branch-1