[HBASE-16311] Audit log for delete snapshot operation is missing in case of snapshot owner deleting the same

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 1.4.0, 2.0.0
• Component/s: snapshots
• Hadoop Flags: Reviewed
• Assignee: Yi Liang
• Reporter: Abhishek Kumar
• Created: 01/Aug/16 12:50
• Updated: 02/Sep/16 20:08
• Resolved: 02/Sep/16 17:14

Description

1. Audit log seems to be left as a TODO task in AccessController.java:

  @Override
  public void preDeleteSnapshot(final ObserverContext<MasterCoprocessorEnvironment> ctx,
      final SnapshotDescription snapshot) throws IOException {
    if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, getActiveUser())) {
      // Snapshot owner is allowed to delete the snapshot
      // TODO: We are not logging this for audit
    } else {
      requirePermission("deleteSnapshot", Action.ADMIN);
    }
  }

2. Also, snapshot name is not getting logged in the audit logs.