Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16225

Refactor ScanQueryMatcher

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.0, 2.0.0
    • 1.4.0, 2.0.0
    • regionserver, Scanners
    • None
    • Reviewed

    Description

      As said in HBASE-16223, the code of ScanQueryMatcher is too complicated. I suggest that we can abstract an interface and implement several sub classes which separate different logic into different implementations. For example, the requirements of compaction and user scan are different, now we also need to consider the logic of user scan even if we only want to add a logic for compaction. And at least, the raw scan does not need a query matcher... we can implement a dummy query matcher for it.

      Suggestions are welcomed. Thanks.

      Attachments

        1. HBASE-16225.patch
          252 kB
          Duo Zhang
        2. HBASE-16225-branch-1.patch
          287 kB
          Duo Zhang
        3. HBASE-16225-branch-1-v1.patch
          287 kB
          Duo Zhang
        4. HBASE-16225-v1.patch
          268 kB
          Duo Zhang
        5. HBASE-16225-v2.patch
          268 kB
          Duo Zhang
        6. HBASE-16225-v3.patch
          277 kB
          Duo Zhang
        7. HBASE-16225-v4.patch
          278 kB
          Duo Zhang
        8. HBASE-16225-v5.patch
          284 kB
          Duo Zhang
        9. HBASE-16225-v6.patch
          291 kB
          Duo Zhang

        Issue Links

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: