Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16215

clean up references for EOM release lines

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: community, website
    • Labels:
      None

      Description

      I've seen us state a few places that 1.0.z is EOM. We should clean up remaining references

      • remove 1.0.z artifact from dist.apache
      • remove it from the ref guide (java prereqs, hadoop prereqs, RM list)
      • remove unreleased 1.0.z versions from JIRA
      • archive released 1.0.z versions in JIRA

      edit: expanded to include

      1. HBASE-16215.0.patch
        22 kB
        Sean Busbey
      2. HBASE-16215.1.patch
        22 kB
        Sean Busbey

        Issue Links

          Activity

          Hide
          busbey Sean Busbey added a comment -

          also update teh dist directory HEADER.html to mark it EOL.

          Show
          busbey Sean Busbey added a comment - also update teh dist directory HEADER.html to mark it EOL.
          Hide
          enis Enis Soztutar added a comment -

          remove 1.0.z artifact from dist.apache

          This is fine. It should be in archive anyway if anybody wants to download.

          remove branch-1.0 from git

          We should keep the branch in git. We do not delete old branches from repo.

          remove unreleased 1.0.z versions from JIRA

          Why? There are still some issues committed to branch-1.0, but not released. In the off-chance that some release will happen, I would opt for keeping history.

          archive released 1.0.z versions in JIRA

          It seems that we have only archived a very small number of versions so far. We need a big cleanup.

          Show
          enis Enis Soztutar added a comment - remove 1.0.z artifact from dist.apache This is fine. It should be in archive anyway if anybody wants to download. remove branch-1.0 from git We should keep the branch in git. We do not delete old branches from repo. remove unreleased 1.0.z versions from JIRA Why? There are still some issues committed to branch-1.0, but not released. In the off-chance that some release will happen, I would opt for keeping history. archive released 1.0.z versions in JIRA It seems that we have only archived a very small number of versions so far. We need a big cleanup.
          Hide
          busbey Sean Busbey added a comment -

          remove branch-1.0 from git

          We should keep the branch in git. We do not delete old branches from repo.

          having it in git leaves the matter of wether folks should be pulling back changes ambiguous. if there are no more planned releases, we should nix the branch so that we don't end up with inconsistent backports (like we have now).

          we delete some old branches from the repo, mostly at the moment it appears to be feature branches that get merged. we should be cleaning up more, but I'm happy to start a DISCUSS thread if folks want to go over relative merits of keeping vs cleaning up.

          remove unreleased 1.0.z versions from JIRA

          Why? There are still some issues committed to branch-1.0, but not released. In the off-chance that some release will happen, I would opt for keeping history.

          Similar to the branch, it leaves ambiguous wether or not we as a project expect fixes to target them. To maintain history, I think we can archive an unreleased version. That would mean archiving 1.0.4 and deleting 1.0.5 (since nothing should be in the later).

          archive released 1.0.z versions in JIRA

          It seems that we have only archived a very small number of versions so far. We need a big cleanup.

          yep. I figured I'd keep this scoped to a particular release line and fix the other stuff later.

          Show
          busbey Sean Busbey added a comment - remove branch-1.0 from git We should keep the branch in git. We do not delete old branches from repo. having it in git leaves the matter of wether folks should be pulling back changes ambiguous. if there are no more planned releases, we should nix the branch so that we don't end up with inconsistent backports (like we have now). we delete some old branches from the repo, mostly at the moment it appears to be feature branches that get merged. we should be cleaning up more, but I'm happy to start a DISCUSS thread if folks want to go over relative merits of keeping vs cleaning up. remove unreleased 1.0.z versions from JIRA Why? There are still some issues committed to branch-1.0, but not released. In the off-chance that some release will happen, I would opt for keeping history. Similar to the branch, it leaves ambiguous wether or not we as a project expect fixes to target them. To maintain history, I think we can archive an unreleased version. That would mean archiving 1.0.4 and deleting 1.0.5 (since nothing should be in the later). archive released 1.0.z versions in JIRA It seems that we have only archived a very small number of versions so far. We need a big cleanup. yep. I figured I'd keep this scoped to a particular release line and fix the other stuff later.
          Hide
          enis Enis Soztutar added a comment -

          we delete some old branches from the repo, mostly at the moment it appears to be feature branches that get merged. we should be cleaning up more, but I'm happy to start a DISCUSS thread if folks want to go over relative merits of keeping vs cleaning up.

          I don't remember deleting a "release" branch at all. Feature branches should be fine, since we don't need to keep history there. There is no overhead of having branches, so if we are doing anything, we should rename branches under archive/branch-1.0 or something to differentiate, but never delete release branches.

          Show
          enis Enis Soztutar added a comment - we delete some old branches from the repo, mostly at the moment it appears to be feature branches that get merged. we should be cleaning up more, but I'm happy to start a DISCUSS thread if folks want to go over relative merits of keeping vs cleaning up. I don't remember deleting a "release" branch at all. Feature branches should be fine, since we don't need to keep history there. There is no overhead of having branches, so if we are doing anything, we should rename branches under archive/branch-1.0 or something to differentiate, but never delete release branches.
          Hide
          busbey Sean Busbey added a comment -

          well, I disagree that there's no overhead. the list of branches could be where folks can look to see the work that is going on. ATM they have to rely on recently changed sorting to gauge where work is actually happening.

          keeping history is good, and I like the archive/foo naming. How about tags? that would mirror our use of 'rel/foo' tags for releases. Then if someone decides to drive an additional release out of one of those release lines it'd be easy enough to start a branch off of e.g. an 'archive/branch-1.0' tag. (or maybe 'archive/eom-1.0' so the word branch isn't there?)

          I'll start a DISCUSS thread. I think we're close enough to agreement to make progress, so we might as well get everyone talking about it now.

          Show
          busbey Sean Busbey added a comment - well, I disagree that there's no overhead. the list of branches could be where folks can look to see the work that is going on. ATM they have to rely on recently changed sorting to gauge where work is actually happening. keeping history is good, and I like the archive/foo naming. How about tags? that would mirror our use of 'rel/foo' tags for releases. Then if someone decides to drive an additional release out of one of those release lines it'd be easy enough to start a branch off of e.g. an 'archive/branch-1.0' tag. (or maybe 'archive/eom-1.0' so the word branch isn't there?) I'll start a DISCUSS thread. I think we're close enough to agreement to make progress, so we might as well get everyone talking about it now.
          Hide
          busbey Sean Busbey added a comment -
          • disable/delete builds.a.o jobs.
          Show
          busbey Sean Busbey added a comment - disable/delete builds.a.o jobs.
          Hide
          busbey Sean Busbey added a comment -

          expanded this to cover the other EOM release lines recently discussed on dev@hbase and user@hbase. i'll start cleaning things up tomorrow unless someone has an objection.

          Show
          busbey Sean Busbey added a comment - expanded this to cover the other EOM release lines recently discussed on dev@hbase and user@hbase. i'll start cleaning things up tomorrow unless someone has an objection.
          Hide
          enis Enis Soztutar added a comment -

          Again, please do not remove the git branches. We need to keep history. It is fine to rename the branches to be under archive or something, but we cannot flat out delete them.

          Show
          enis Enis Soztutar added a comment - Again, please do not remove the git branches. We need to keep history. It is fine to rename the branches to be under archive or something, but we cannot flat out delete them.
          Hide
          busbey Sean Busbey added a comment -

          updated the description to make clear that we tabled the whole git branch thing.

          Show
          busbey Sean Busbey added a comment - updated the description to make clear that we tabled the whole git branch thing.
          Hide
          busbey Sean Busbey added a comment -
          Show
          busbey Sean Busbey added a comment - asf dist has been updated
          Hide
          busbey Sean Busbey added a comment - - edited
          • all but the most recent unreleased JIRA version for each line have been removed (with issues attached to later unreleased versions moved to said version). each has a note about EOM (e.g. there's still a 0.98.25 version and it says the line is EOM)

          edit: this was poorly phrased. released JIRA versions haven't been changed, just to be clear.

          Show
          busbey Sean Busbey added a comment - - edited all but the most recent unreleased JIRA version for each line have been removed (with issues attached to later unreleased versions moved to said version). each has a note about EOM (e.g. there's still a 0.98.25 version and it says the line is EOM) edit: this was poorly phrased. released JIRA versions haven't been changed, just to be clear.
          Hide
          busbey Sean Busbey added a comment -
          • builds.a.o jobs have been disabled (only 0.98 still had some)
          Show
          busbey Sean Busbey added a comment - builds.a.o jobs have been disabled (only 0.98 still had some)
          Hide
          busbey Sean Busbey added a comment -

          -00

          • updates to ref guide to remove 0.98, 0.94, and 1.0 prereqs
          • updates ref guide to remove many references to EOM version specific behavior
          • updates site to remove link to 0.94 docs (but leaves the docs themselves in place to avoid breaking external linkers)
          Show
          busbey Sean Busbey added a comment - -00 updates to ref guide to remove 0.98, 0.94, and 1.0 prereqs updates ref guide to remove many references to EOM version specific behavior updates site to remove link to 0.94 docs (but leaves the docs themselves in place to avoid breaking external linkers)
          Hide
          enis Enis Soztutar added a comment -

          +1. Thanks for the clean up.
          Are we removing the "The "Singularity" section as well?
          Also we should delete the 0.94 documentation from the website?

          Show
          enis Enis Soztutar added a comment - +1. Thanks for the clean up. Are we removing the "The "Singularity" section as well? Also we should delete the 0.94 documentation from the website?
          Hide
          busbey Sean Busbey added a comment -

          Are we removing the "The "Singularity" section as well?

          I figured we'd leave all the upgrade stuff in place. I think the singularity section is a part of that. I'm open to removing more stuff if folks think it's needed.

          Also we should delete the 0.94 documentation from the website?

          I was gonna leave it in place for now since folks might be linking to it. I'm also fine with just deleting it. I don't know if we have stats on how used that section of the site is.

          Show
          busbey Sean Busbey added a comment - Are we removing the "The "Singularity" section as well? I figured we'd leave all the upgrade stuff in place. I think the singularity section is a part of that. I'm open to removing more stuff if folks think it's needed. Also we should delete the 0.94 documentation from the website? I was gonna leave it in place for now since folks might be linking to it. I'm also fine with just deleting it. I don't know if we have stats on how used that section of the site is.
          Hide
          stack stack added a comment -

          Cosmin Lehene just noted that a search for 'hbase standalone' turns up the 0.94 doc in gsearch.

          Show
          stack stack added a comment - Cosmin Lehene just noted that a search for 'hbase standalone' turns up the 0.94 doc in gsearch.
          Hide
          busbey Sean Busbey added a comment -

          we can probably correct that through some search engine pointers, but I'd rather do it in follow up (presuming we don't want to "solve" it by deleting 0.94 docs)

          Show
          busbey Sean Busbey added a comment - we can probably correct that through some search engine pointers, but I'd rather do it in follow up (presuming we don't want to "solve" it by deleting 0.94 docs)
          Hide
          busbey Sean Busbey added a comment -

          bump. folks okay with dealing with 0.94 doc prioritization in google later? fine with leaving upgrade docs in place? fine with leaving an unlinked copy of the 0.94 docs around?

          Show
          busbey Sean Busbey added a comment - bump. folks okay with dealing with 0.94 doc prioritization in google later? fine with leaving upgrade docs in place? fine with leaving an unlinked copy of the 0.94 docs around?
          Hide
          busbey Sean Busbey added a comment -

          01

          • minor format tweak on notes about java versions.
          Show
          busbey Sean Busbey added a comment - 01 minor format tweak on notes about java versions.
          Hide
          stack stack added a comment -

          bump. folks okay with dealing with 0.94 doc prioritization in google later?

          Fine by me sir.

          Show
          stack stack added a comment - bump. folks okay with dealing with 0.94 doc prioritization in google later? Fine by me sir.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 3s master passed
          +1 mvneclipse 1m 26s master passed
          +1 javadoc 2m 12s master passed
          +1 mvninstall 3m 12s the patch passed
          +1 mvneclipse 1m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 hadoopcheck 28m 34s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 javadoc 2m 6s the patch passed
          -1 unit 126m 1s root in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          168m 57s



          Reason Tests
          Failed junit tests hadoop.hbase.snapshot.TestExportSnapshot
            hadoop.hbase.snapshot.TestMobExportSnapshot
            hadoop.hbase.snapshot.TestSecureExportSnapshot



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12863645/HBASE-16215.1.patch
          JIRA Issue HBASE-16215
          Optional Tests asflicense javac javadoc unit xml
          uname Linux 8066e9fe0a7f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / c2c2178
          Default Java 1.8.0_121
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6468/artifact/patchprocess/patch-unit-root.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6468/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6468/testReport/
          modules C: . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6468/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 3s master passed +1 mvneclipse 1m 26s master passed +1 javadoc 2m 12s master passed +1 mvninstall 3m 12s the patch passed +1 mvneclipse 1m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 hadoopcheck 28m 34s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 javadoc 2m 6s the patch passed -1 unit 126m 1s root in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 168m 57s Reason Tests Failed junit tests hadoop.hbase.snapshot.TestExportSnapshot   hadoop.hbase.snapshot.TestMobExportSnapshot   hadoop.hbase.snapshot.TestSecureExportSnapshot Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12863645/HBASE-16215.1.patch JIRA Issue HBASE-16215 Optional Tests asflicense javac javadoc unit xml uname Linux 8066e9fe0a7f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / c2c2178 Default Java 1.8.0_121 unit https://builds.apache.org/job/PreCommit-HBASE-Build/6468/artifact/patchprocess/patch-unit-root.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6468/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6468/testReport/ modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6468/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

          docs patch, no new tests should be needed.

          Reason Tests
          Failed junit tests hadoop.hbase.snapshot.TestExportSnapshot
          hadoop.hbase.snapshot.TestMobExportSnapshot
          hadoop.hbase.snapshot.TestSecureExportSnapshot

          I don't see how the docs change would have caused all the snapshot tests to start failing.

          Show
          busbey Sean Busbey added a comment - -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. docs patch, no new tests should be needed. Reason Tests Failed junit tests hadoop.hbase.snapshot.TestExportSnapshot hadoop.hbase.snapshot.TestMobExportSnapshot hadoop.hbase.snapshot.TestSecureExportSnapshot I don't see how the docs change would have caused all the snapshot tests to start failing.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2884 (See https://builds.apache.org/job/HBase-Trunk_matrix/2884/)
          HBASE-16215 clean up of ref guide and site for EOM versions. (busbey: rev a8e6f33791d787eaf9c1bfe63aa7f3266f25268b)

          • (edit) src/main/asciidoc/_chapters/configuration.adoc
          • (edit) src/main/asciidoc/_chapters/upgrading.adoc
          • (edit) src/main/asciidoc/_chapters/developer.adoc
          • (edit) src/main/asciidoc/_chapters/cp.adoc
          • (edit) src/main/site/site.xml
          • (edit) src/main/asciidoc/_chapters/community.adoc
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2884 (See https://builds.apache.org/job/HBase-Trunk_matrix/2884/ ) HBASE-16215 clean up of ref guide and site for EOM versions. (busbey: rev a8e6f33791d787eaf9c1bfe63aa7f3266f25268b) (edit) src/main/asciidoc/_chapters/configuration.adoc (edit) src/main/asciidoc/_chapters/upgrading.adoc (edit) src/main/asciidoc/_chapters/developer.adoc (edit) src/main/asciidoc/_chapters/cp.adoc (edit) src/main/site/site.xml (edit) src/main/asciidoc/_chapters/community.adoc
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Jenkins build HBase-HBASE-14614 #190 (See https://builds.apache.org/job/HBase-HBASE-14614/190/)
          HBASE-16215 clean up of ref guide and site for EOM versions. (busbey: rev a8e6f33791d787eaf9c1bfe63aa7f3266f25268b)

          • (edit) src/main/asciidoc/_chapters/community.adoc
          • (edit) src/main/asciidoc/_chapters/cp.adoc
          • (edit) src/main/asciidoc/_chapters/upgrading.adoc
          • (edit) src/main/asciidoc/_chapters/configuration.adoc
          • (edit) src/main/site/site.xml
          • (edit) src/main/asciidoc/_chapters/developer.adoc
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Jenkins build HBase- HBASE-14614 #190 (See https://builds.apache.org/job/HBase-HBASE-14614/190/ ) HBASE-16215 clean up of ref guide and site for EOM versions. (busbey: rev a8e6f33791d787eaf9c1bfe63aa7f3266f25268b) (edit) src/main/asciidoc/_chapters/community.adoc (edit) src/main/asciidoc/_chapters/cp.adoc (edit) src/main/asciidoc/_chapters/upgrading.adoc (edit) src/main/asciidoc/_chapters/configuration.adoc (edit) src/main/site/site.xml (edit) src/main/asciidoc/_chapters/developer.adoc

            People

            • Assignee:
              busbey Sean Busbey
              Reporter:
              busbey Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development