[HBASE-16133] RSGroupBasedLoadBalancer.retainAssignment() might miss a region

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Enis Soztutar
• Reporter: Enis Soztutar
• Created: 28/Jun/16 03:09
• Updated: 06/Jul/17 01:43
• Resolved: 01/Jul/16 16:34

Description

We have seen in the tests through the IntegrationTestRSGroup that we may miss assigning a region.

It is a simple logic error here:

        if (server != null && !assignments.containsKey(server)) {
          assignments.put(server, new ArrayList<HRegionInfo>());
        } else if (server != null) {
           assignments.get(server).add(region);
         } else {

in the first condition, we are not adding the region to the newly created ArrayList.

Issue Links

• is related to: HBASE-15631 Backport Regionserver Groups (HBASE-6721) to branch-1