[HBASE-16096] Replication keeps accumulating znodes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 1.3.0, 2.0.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: Replication
• Hadoop Flags: Reviewed
• Assignee: Joseph
• Reporter: Ashu Pachauri
• Created: 23/Jun/16 21:02
• Updated: 24/Jun/22 19:11
• Resolved: 28/Jul/16 18:32

Description

If there is an error while creating the replication source on adding the peer, the source if not added to the in memory list of sources but the replication peer is.
However, in such a scenario, when you remove the peer, it is deleted from zookeeper successfully but for removing the in memory list of peers, we wait for the corresponding sources to get deleted (which as we said don't exist because of error creating the source).
The problem here is the ordering of operations for adding/removing source and peer.
Modifying the code to always remove queues from the underlying storage, even if there exists no sources also requires a small refactoring of TableBasedReplicationQueuesImpl to not abort on removeQueues() of an empty queue

Issue Links

• is depended upon by: HBASE-15867 Move HBase replication tracking from ZooKeeper to HBase