Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15940

HBCK unnecessary moves reference files when a table has split region to fix non-existing overlap regions

Add voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 1.0.0
    • None
    • hbck
    • None

    Description

      When repair option (the -fixHdfsOverlaps option specifically) is specified against a table, if the table has splitted regions (both parent region and child regions exists with reference files), Hbck would wrongly think that there exists overlapped regions and try to merge them and fix it.

      This is by-design, as current implementation of Hbck uses HDFS as the trusted source without consulting META table.

      Here is the comments from one of unit tests:

            // TODO: fixHdfsHoles does not work against splits, since the parent dir lingers on
            // for some time until children references are deleted. HBCK erroneously sees this as
            // overlapping regions
      

      However, this is undesirable. when the reference files moved to a new region, the parent region would have no daugher regions and hence it could be cleaned up by CatalogJanitor. This would create real inconsistency: lingering reference files.

      Another bad consequence is that we would merge splitted regions back to one. Even it is undesirable, at least this would not cause more inconsistency. this JIRA would not try to solve this unsplit issue, as it requires bigger design change in Hbck.

      This JIRA is trying to address the potential lingering reference files issue, as multiple customers using branch-1 faced this issue in production. (workaround is that run major compaction on all split regions before run HBCK, this could take longer time and have production impact).

      Attached is the log and modified unit test to repro the issue.

      Attachments

        1. skipReferenceFiles.patch
          2 kB
          Stephen Yuan Jiang
        2. repro-hbck-repair-healthy-splitted=region.patch
          19 kB
          Stephen Yuan Jiang
        3. org.apache.hadoop.hbase.util.TestHBaseFsck-output.txt
          694 kB
          Stephen Yuan Jiang

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            syuanjiang Stephen Yuan Jiang
            syuanjiang Stephen Yuan Jiang

            Dates

              Created:
              Updated:

              Slack

                Issue deployment