[HBASE-15803] ZooKeeperWatcher's constructor can leak a ZooKeeper instance with throwing ZooKeeperConnectionException when canCreateBaseZNode is true

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.4.0, 0.98.20, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Hiroshi Ikeda
• Created: 09/May/16 06:14
• Updated: 08/Jun/16 17:20
• Resolved: 07/Jun/16 16:14

Description

  public ZooKeeperWatcher(Configuration conf, String identifier,
      Abortable abortable, boolean canCreateBaseZNode)
  throws IOException, ZooKeeperConnectionException {
...skip...
    this.recoverableZooKeeper = ZKUtil.connect(...
...skip...
    if (canCreateBaseZNode) {
      createBaseZNodes();
    }
  }

  private void createBaseZNodes() throws ZooKeeperConnectionException {

The registered watcher doesn't seem to close the Zookeeper instance by watch events, and the instance keeps alive when createBaseZNodes is failed.