Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15742

Reduce allocation of objects in metrics

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 1.2.1, 1.0.3, 1.1.4, 0.98.19
    • Fix Version/s: 1.3.0, 1.1.5, 1.2.2, 0.98.20, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We use JMX and o.a.h.metrics2 to do some metrics on regions, tables, region servers and cluster. We use MetricsInfo to show the information of metrics, and we use Interns to cache MetricsInfo objects because it won't be changed.

      However, in Interns there are some static values to limit the max cached objects. We can only cache 2010 metrics, but we have dozens of metrics for one region and we have some RS-level metrics in each RS and all metrics for all regions will be saved in master. So each server will have thousands of metrics, and we can not cache most of them. When we collect metrics by JMX, we will create many objects which can be avoid. It increases the pressure of GC and JMX has some caching logic so the objects can not be removed immediately which increases the pressure more.

      Interns is in Hadoop project, and I think the implementation is not suitable for HBase. Because we can not know how many MetricsInfo we have, it depends on the number of regions. And we can not set it unlimited because we should remove the objects whose region is split, moved, or dropped. I think we can use Guava's cache with expireAfterAccess which is very simple and convenient.

      So we can add a new Interns class in HBase project first, and put it to upstream later.

      Moreover, in MutableHistogram#snapshot we create same Strings each time, we can create them only in the first time.

        Attachments

        1. 15742.0.98.patch
          1.0 kB
          Phil Yang
        2. HBASE-15742-0.98.v1.patch
          15 kB
          Phil Yang
        3. HBASE-15742-0.98.v2.patch
          18 kB
          Phil Yang
        4. HBASE-15742-branch-1.1-v1.patch
          17 kB
          Phil Yang
        5. HBASE-15742-branch-1.2-v1.patch
          19 kB
          Phil Yang
        6. HBASE-15742-branch-1.2-v2.patch
          19 kB
          Phil Yang
        7. HBASE-15742-branch-1-v1.patch
          23 kB
          Phil Yang
        8. HBASE-15742-v1.patch
          23 kB
          Phil Yang
        9. HBASE-15742-v2.patch
          23 kB
          Phil Yang
        10. HBASE-15742-v3.patch
          23 kB
          Phil Yang
        11. HBASE-15742-v4.patch
          23 kB
          Phil Yang

          Activity

            People

            • Assignee:
              yangzhe1991 Phil Yang
              Reporter:
              yangzhe1991 Phil Yang

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment