Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15240 Go Big BucketCache Fixes
  3. HBASE-15691

Port HBASE-10205 (ConcurrentModificationException in BucketAllocator) to branch-1

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.0, 1.3.2, 1.1.12, 1.2.7
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBASE-10205 solves the following problem:
      "
      The BucketCache WriterThread calls BucketCache.freeSpace() upon draining the RAM queue containing entries to be cached. freeSpace() in turn calls BucketSizeInfo.statistics() through BucketAllocator.getIndexStatistics(), which iterates over 'bucketList'. At the same time another WriterThread might call BucketAllocator.allocateBlock(), which may call BucketSizeInfo.allocateBlock(), add a bucket to 'bucketList' and consequently cause a ConcurrentModificationException. Calls to BucketAllocator.allocateBlock() are synchronized, but calls to BucketAllocator.getIndexStatistics() are not, which allows this race to occur.
      "

      However, for some unknown reason, HBASE-10205 was only committed to master (2.0 and beyond) and 0.98 branches only. To preserve continuity we should commit it to branch-1.

        Attachments

        1. HBASE-15691.v3-branch-1.patch
          2 kB
          Stephen Yuan Jiang
        2. HBASE-15691.v2-branch-1.patch
          2 kB
          Stephen Yuan Jiang
        3. HBASE-15691-branch-1.patch
          5 kB
          Andrew Kyle Purtell

          Issue Links

            Activity

              People

              • Assignee:
                syuanjiang Stephen Yuan Jiang
                Reporter:
                apurtell Andrew Kyle Purtell
              • Votes:
                0 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: