[HBASE-15501] MultiAction.add creates unnecessary temporary objects

• Type: Improvement
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.0.0
• Component/s: Client
• Assignee: Vladimir Rodionov
• Reporter: Vladimir Rodionov
• Created: 21/Mar/16 18:23
• Updated: 30/Jun/17 10:50

Description

MultiAction class:

  /**
   * Add an Action to this container based on it's regionName. If the regionName
   * is wrong, the initial execution will fail, but will be automatically
   * retried after looking up the correct region.
   *
   * @param regionName
   * @param a
   */
  public void add(byte[] regionName, Action<R> a) {
    add(regionName, Arrays.asList(a));
  }

  /**
   * Add an Action to this container based on it's regionName. If the regionName
   * is wrong, the initial execution will fail, but will be automatically
   * retried after looking up the correct region.
   *
   * @param regionName
   * @param actionList list of actions to add for the region
   */
  public void add(byte[] regionName, List<Action<R>> actionList){
    List<Action<R>> rsActions = actions.get(regionName);
    if (rsActions == null) {
      rsActions = new ArrayList<Action<R>>(actionList.size());
      actions.put(regionName, rsActions);
    }
    rsActions.addAll(actionList);
  }

Avoid Arrays.asList(a) and Collection.addAll - they create temporary garbage

Issue Links

• is part of: HBASE-15492 Memory usage optimizations