[HBASE-15456] CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: master
• Hadoop Flags: Reviewed
• Assignee: Hua Xiang
• Reporter: Hua Xiang
• Created: 14/Mar/16 17:59
• Updated: 09/Nov/17 00:14
• Resolved: 18/Mar/16 17:25

Description

If there is only one family in the table, DeleteColumnFamilyProcedure will fail.
Currently, when hbase.table.sanity.checks is set to false, hbase master logs a warning and CreateTableProcedure/ModifyTableProcedure will succeed.
This behavior is not consistent with DeleteColumnFamilyProcedure's.

Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the following exception. lastStoreFlushTimeMap is populated for families, if there is no family in the table, there is no entry in lastStoreFlushTimeMap.

16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: Caught exception 
java.util.NoSuchElementException 
at java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) 
at java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) 
at java.util.Collections.min(Collections.java:628) 
at org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) 
at org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) 
at org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) 
at org.apache.hadoop.hbase.Chore.run(Chore.java:87) 
at java.lang.Thread.run(Thread.java:745)