Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15161 Umbrella: Miscellaneous improvements from production usage
  3. HBASE-15377

Per-RS Get metric is time based, per-region metric is size-based

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.3.0, 2.0.0
    • None
    • None
    • Incompatible change, Reviewed
    • Hide
      Per-region metrics related to Get histograms are changed from being response size based into being latency based similar to the per-regionserver metrics of the same name.

      Added GetSize histogram metrics at the per-regionserver and per-region level for the response sizes.
      Show
      Per-region metrics related to Get histograms are changed from being response size based into being latency based similar to the per-regionserver metrics of the same name. Added GetSize histogram metrics at the per-regionserver and per-region level for the response sizes.

    Description

      We have metrics for Get operations at the region server level and region level.

         "Get_num_ops" : 4837505,
          "Get_min" : 0,
          "Get_max" : 296,
          "Get_mean" : 0.2934618155433431,
          "Get_median" : 0.0,
          "Get_75th_percentile" : 0.0,
          "Get_95th_percentile" : 1.0,
          "Get_99th_percentile" : 1.0,
      

      and

         "Namespace_hbase_table_meta_region_1588230740_metric_get_num_ops" : 103,
          "Namespace_hbase_table_meta_region_1588230740_metric_get_min" : 450,
          "Namespace_hbase_table_meta_region_1588230740_metric_get_max" : 470,
          "Namespace_hbase_table_meta_region_1588230740_metric_get_mean" : 450.19417475728153,
          "Namespace_hbase_table_meta_region_1588230740_metric_get_median" : 460.0,
          "Namespace_hbase_table_meta_region_1588230740_metric_get_75th_percentile" : 470.0,
          "Namespace_hbase_table_meta_region_1588230740_metric_get_95th_percentile" : 470.0,
          "Namespace_hbase_table_meta_region_1588230740_metric_get_99th_percentile" : 470.0,
      

      The problem is that the report values for the region server shows the latency, versus the reported values for the region shows the response sizes. There is no way of telling this without reading the source code.

      I think we should deprecate response size histograms in favor of latency histograms.

      See also HBASE-15376.

      Attachments

        1. HBASE-15377.patch
          15 kB
          Heng Chen
        2. HBASE-15377_v2.patch
          11 kB
          Heng Chen
        3. HBASE-15377_v2.patch
          11 kB
          Enis Soztutar
        4. HBASE-15377_v2.patch
          11 kB
          Enis Soztutar
        5. HBASE-15377_v1.patch
          15 kB
          Heng Chen

        Activity

          People

            chenheng Heng Chen
            enis Enis Soztutar
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: