Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15324

Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger unexpected split

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.1.3, 2.0.0
    • 1.3.0, 1.2.5, 1.1.8, 2.0.0
    • None
    • None
    • Reviewed

    Description

      We introduce jitter for region split decision in HBASE-13412, but the following line in ConstantSizeRegionSplitPolicy may cause long value overflow if MAX_FILESIZE is specified to Long.MAX_VALUE:

      this.desiredMaxFileSize += (long)(desiredMaxFileSize * (RANDOM.nextFloat() - 0.5D) * jitter);
      

      In our case we specify MAX_FILESIZE to Long.MAX_VALUE to prevent target region to split.

      Attachments

        1. HBASE-15324.patch
          1 kB
          Yu Li
        2. HBASE-15324_v2.patch
          4 kB
          Yu Li
        3. HBASE-15324_v3.patch
          4 kB
          Yu Li
        4. HBASE-15324_v3.patch
          4 kB
          Michael Stack

        Issue Links

          Activity

            People

              liyu Yu Li
              liyu Yu Li
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: