[HBASE-15260] Should we check zero length value in checkAndMutate when null is passes as expected value?

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Ankit Singhal
• Created: 12/Feb/16 17:35
• Updated: 25/Feb/16 08:50

Description

Should we check zero length value in checkAndMutate when null is passes as expected value?
If yes, then I think we should update the documentation for checkAndPut with the same as sometimes column are used for marker with empty byte array.

If the passed value is null, the check
   * is for the lack of column (ie: non-existance)
boolean checkAndPut(byte[] row, byte[] family, byte[] qualifier,
    byte[] value, Put put) throws IOException;

otherwise , we should remove this check.

HRegion.class

@Override
  public boolean checkAndMutate(byte [] row, byte [] family, byte [] qualifier,
      CompareOp compareOp, ByteArrayComparable comparator, Mutation w,
      boolean writeToWAL)
  throws IOException{
...
else if (result.size() > 0 && result.get(0).getValueLength() == 0 &&
            valueIsNull) {
          matches = true;
        }