Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15229

Canary Tools should not call System.Exit on error

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.98.17
    • Fix Version/s: 1.2.0, 1.3.0, 0.98.18, 2.0.0
    • Component/s: canary
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      run method in canary tool calls system.Exit on failure. Due to this it can't be integrated as an API as jvm will stop on failure. It should only return (exit code)

      So any integration with unit test also fail with

      [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on project <>: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ?
      

        Attachments

        1. HBASE-15229.patch
          2 kB
          Andrew Kyle Purtell
        2. HBASE-15229.v1.patch
          2 kB
          Vishal Khandelwal
        3. HBASE-15229.v2.patch
          16 kB
          Vishal Khandelwal
        4. HBASE-15229.v3.patch
          3 kB
          Vishal Khandelwal
        5. HBASE-15229-0.98.patch
          2 kB
          Andrew Kyle Purtell

          Activity

            People

            • Assignee:
              vishk Vishal Khandelwal
              Reporter:
              vishk Vishal Khandelwal
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: