[HBASE-15229] Canary Tools should not call System.Exit on error

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.98.17
• Fix Version/s: 1.2.0, 1.3.0, 0.98.18, 2.0.0
• Component/s: canary
• Hadoop Flags: Reviewed
• Assignee: Vishal Khandelwal
• Reporter: Vishal Khandelwal
• Created: 08/Feb/16 11:16
• Updated: 13/Feb/16 16:28
• Resolved: 10/Feb/16 18:32

Description

run method in canary tool calls system.Exit on failure. Due to this it can't be integrated as an API as jvm will stop on failure. It should only return (exit code)

So any integration with unit test also fail with

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on project <>: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ?