Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15218

On RS crash and replay of WAL, loosing all Tags in Cells

    XMLWordPrintableJSON

Details

    • Reviewed
    • Hide
      This issue fixes
      - In case of normal WAL (Not encrypted) we were loosing all cell tags on WAL replay after an RS crash
      - In case of encrypted WAL we were not even persisting Cell tags in WAL. Tags from all unflushed (to HFile) Cells will get lost even after WAL replay recovery is done.

      As we use tags for Cell level security, this fixes 2 security issues
       - Cell level visibility labels security breach . Making a visibility restricted cell global readable
       - Cell level ACL availability issue. A user who is cell level authorized to read this cell can not read it. It is a data loss for him.
      Show
      This issue fixes - In case of normal WAL (Not encrypted) we were loosing all cell tags on WAL replay after an RS crash - In case of encrypted WAL we were not even persisting Cell tags in WAL. Tags from all unflushed (to HFile) Cells will get lost even after WAL replay recovery is done. As we use tags for Cell level security, this fixes 2 security issues  - Cell level visibility labels security breach . Making a visibility restricted cell global readable  - Cell level ACL availability issue. A user who is cell level authorized to read this cell can not read it. It is a data loss for him.

    Description

      The KeyValueCodec's Decoder makes NoTagsKeyValue. The WalCellCodec also makes this Decoder and so while reading Cells after RS crash, we will loose all tags in Cells. (While writing to WAL using WALCellCodec, we are preserving Cell tags.)
      In case of SecureWALCellCodec, we are not even writing Cell tags to WAL.

      Attachments

        1. HBASE-15218.patch
          5 kB
          Anoop Sam John
        2. HBASE-15218-0.98.patch
          5 kB
          Anoop Sam John
        3. HBASE-15218-branch-1.1.patch
          5 kB
          Anoop Sam John
        4. HBASE-15218-branch-1.2.patch
          5 kB
          Anoop Sam John

        Issue Links

          Activity

            People

              anoop.hbase Anoop Sam John
              anoop.hbase Anoop Sam John
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: