Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15134

Add visibility into Flush and Compaction queues

    Details

    • Hadoop Flags:
      Reviewed

      Description

      On busy spurts we can see regionservers start to see large queues for compaction. It's really hard to tell if the server is queueing a lot of compactions for the same region, lots of compactions for lots of regions, or just falling behind.

      For flushes much the same. There can be flushes in queue that aren't being run because of delayed flushes. There's no way to know from the metrics how many flushes are for each region, how many are delayed. Etc.

      We should add either more metrics around this ( num per region, max per region, min per region ) or add on a UI page that has the list of compactions and flushes.

      Or both.

      1. HBASE-15134.branch-1.001.patch
        17 kB
        Abhishek Singh Chouhan
      2. HBASE-15134.branch-1.001.patch
        17 kB
        Abhishek Singh Chouhan
      3. HBASE-15134.master.001.patch
        17 kB
        Abhishek Singh Chouhan
      4. HBASE-15134.master.002.patch
        17 kB
        Abhishek Singh Chouhan
      5. HBASE-15134.master.003.patch
        17 kB
        Abhishek Singh Chouhan
      6. HBASE-15134.patch
        13 kB
        Abhishek Singh Chouhan
      7. HBASE-15134.patch
        12 kB
        Abhishek Singh Chouhan

        Activity

        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Elliott Clark Mind if i have a go at this one?

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Elliott Clark Mind if i have a go at this one?
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Initial patch that adds a metric per region of flushes queued and compactions queued for that region.

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Initial patch that adds a metric per region of flushes queued and compactions queued for that region.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Getting a QA run

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Getting a QA run
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 18s Maven dependency ordering for branch
        +1 mvninstall 3m 9s master passed
        +1 compile 0m 49s master passed with JDK v1.8.0_101
        +1 compile 0m 56s master passed with JDK v1.7.0_111
        +1 checkstyle 0m 31s master passed
        +1 mvneclipse 0m 37s master passed
        +1 findbugs 2m 45s master passed
        +1 javadoc 0m 44s master passed with JDK v1.8.0_101
        +1 javadoc 0m 56s master passed with JDK v1.7.0_111
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 8s the patch passed
        +1 compile 0m 49s the patch passed with JDK v1.8.0_101
        +1 javac 0m 49s the patch passed
        +1 compile 0m 56s the patch passed with JDK v1.7.0_111
        +1 javac 0m 56s the patch passed
        +1 checkstyle 0m 30s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        -1 whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 0m 0s The patch 13 line(s) with tabs.
        +1 hadoopcheck 27m 37s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
        +1 hbaseprotoc 0m 33s the patch passed
        +1 findbugs 3m 18s the patch passed
        +1 javadoc 0m 44s the patch passed with JDK v1.8.0_101
        +1 javadoc 0m 56s the patch passed with JDK v1.7.0_111
        +1 unit 0m 17s hbase-hadoop-compat in the patch passed.
        +1 unit 0m 21s hbase-hadoop2-compat in the patch passed.
        -1 unit 15m 38s hbase-server in the patch failed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        66m 1s



        Reason Tests
        Failed junit tests hadoop.hbase.io.TestHeapSize



        Subsystem Report/Notes
        Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-01
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826576/HBASE-15134.patch
        JIRA Issue HBASE-15134
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux 58065e46a6f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision master / e30a66b
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/3376/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/3376/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/3376/artifact/patchprocess/patch-unit-hbase-server.txt
        unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/3376/artifact/patchprocess/patch-unit-hbase-server.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3376/testReport/
        modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3376/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 3m 9s master passed +1 compile 0m 49s master passed with JDK v1.8.0_101 +1 compile 0m 56s master passed with JDK v1.7.0_111 +1 checkstyle 0m 31s master passed +1 mvneclipse 0m 37s master passed +1 findbugs 2m 45s master passed +1 javadoc 0m 44s master passed with JDK v1.8.0_101 +1 javadoc 0m 56s master passed with JDK v1.7.0_111 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 0m 49s the patch passed with JDK v1.8.0_101 +1 javac 0m 49s the patch passed +1 compile 0m 56s the patch passed with JDK v1.7.0_111 +1 javac 0m 56s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvneclipse 0m 35s the patch passed -1 whitespace 0m 0s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 0s The patch 13 line(s) with tabs. +1 hadoopcheck 27m 37s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 hbaseprotoc 0m 33s the patch passed +1 findbugs 3m 18s the patch passed +1 javadoc 0m 44s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 56s the patch passed with JDK v1.7.0_111 +1 unit 0m 17s hbase-hadoop-compat in the patch passed. +1 unit 0m 21s hbase-hadoop2-compat in the patch passed. -1 unit 15m 38s hbase-server in the patch failed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 66m 1s Reason Tests Failed junit tests hadoop.hbase.io.TestHeapSize Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-01 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826576/HBASE-15134.patch JIRA Issue HBASE-15134 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 58065e46a6f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / e30a66b Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/3376/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/3376/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/3376/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/3376/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3376/testReport/ modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3376/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Fixing Heap Test And Checkstyle

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Fixing Heap Test And Checkstyle
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 39s Maven dependency ordering for branch
        +1 mvninstall 3m 20s master passed
        +1 compile 0m 51s master passed with JDK v1.8.0_101
        +1 compile 0m 56s master passed with JDK v1.7.0_111
        +1 checkstyle 0m 33s master passed
        +1 mvneclipse 0m 37s master passed
        +1 findbugs 2m 45s master passed
        +1 javadoc 0m 44s master passed with JDK v1.8.0_101
        +1 javadoc 0m 57s master passed with JDK v1.7.0_111
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 8s the patch passed
        +1 compile 0m 49s the patch passed with JDK v1.8.0_101
        +1 javac 0m 49s the patch passed
        +1 compile 0m 57s the patch passed with JDK v1.7.0_111
        +1 javac 0m 57s the patch passed
        +1 checkstyle 0m 31s the patch passed
        +1 mvneclipse 0m 37s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 27m 46s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
        +1 hbaseprotoc 0m 32s the patch passed
        +1 findbugs 3m 19s the patch passed
        +1 javadoc 0m 44s the patch passed with JDK v1.8.0_101
        +1 javadoc 0m 57s the patch passed with JDK v1.7.0_111
        +1 unit 0m 17s hbase-hadoop-compat in the patch passed.
        +1 unit 0m 21s hbase-hadoop2-compat in the patch passed.
        -1 unit 94m 8s hbase-server in the patch failed.
        +1 asflicense 0m 50s The patch does not generate ASF License warnings.
        145m 43s



        Reason Tests
        Failed junit tests hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush



        Subsystem Report/Notes
        Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-01
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826590/HBASE-15134.patch
        JIRA Issue HBASE-15134
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux 0ed9f53e9424 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision master / e30a66b
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/3378/artifact/patchprocess/patch-unit-hbase-server.txt
        unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/3378/artifact/patchprocess/patch-unit-hbase-server.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3378/testReport/
        modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3378/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 39s Maven dependency ordering for branch +1 mvninstall 3m 20s master passed +1 compile 0m 51s master passed with JDK v1.8.0_101 +1 compile 0m 56s master passed with JDK v1.7.0_111 +1 checkstyle 0m 33s master passed +1 mvneclipse 0m 37s master passed +1 findbugs 2m 45s master passed +1 javadoc 0m 44s master passed with JDK v1.8.0_101 +1 javadoc 0m 57s master passed with JDK v1.7.0_111 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 0m 49s the patch passed with JDK v1.8.0_101 +1 javac 0m 49s the patch passed +1 compile 0m 57s the patch passed with JDK v1.7.0_111 +1 javac 0m 57s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 27m 46s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 hbaseprotoc 0m 32s the patch passed +1 findbugs 3m 19s the patch passed +1 javadoc 0m 44s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 57s the patch passed with JDK v1.7.0_111 +1 unit 0m 17s hbase-hadoop-compat in the patch passed. +1 unit 0m 21s hbase-hadoop2-compat in the patch passed. -1 unit 94m 8s hbase-server in the patch failed. +1 asflicense 0m 50s The patch does not generate ASF License warnings. 145m 43s Reason Tests Failed junit tests hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-01 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826590/HBASE-15134.patch JIRA Issue HBASE-15134 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 0ed9f53e9424 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / e30a66b Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/3378/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/3378/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3378/testReport/ modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3378/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Elliott Clark Anoop Sam John Does this patch looks heading in the right direction?
        I thought about adding a metric to keep a track of the max too but the only possibilities looked either to have it in "org.apache.hadoop.hbase.regionserver.MetricsRegionWrapperImpl.HRegionMetricsWrapperRunnable" in which case it might not report correctly since its run at an interval of 45 seconds by which time we might have hit max queue count and cleared off too. Other seemed doing a check everytime a request is queued against a prev max but this would also have to be synchronized (not very sure if thats a good idea). Any thoughts ?

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Elliott Clark Anoop Sam John Does this patch looks heading in the right direction? I thought about adding a metric to keep a track of the max too but the only possibilities looked either to have it in "org.apache.hadoop.hbase.regionserver.MetricsRegionWrapperImpl.HRegionMetricsWrapperRunnable" in which case it might not report correctly since its run at an interval of 45 seconds by which time we might have hit max queue count and cleared off too. Other seemed doing a check everytime a request is queued against a prev max but this would also have to be synchronized (not very sure if thats a good idea). Any thoughts ?
        Hide
        busbey Sean Busbey added a comment -

        Thanks for your work on this so far!

        we should avoid needing synchronization unless we need it for correctness. generally, an approximation should be fine for metrics like this.

        in the future, please use `git format-patch` to create your patches, so we get a commit message and your preferred authorship line. For more details on this, and pointers to some helper scripts see the ref guide section on submitting patches

        Show
        busbey Sean Busbey added a comment - Thanks for your work on this so far! we should avoid needing synchronization unless we need it for correctness. generally, an approximation should be fine for metrics like this. in the future, please use `git format-patch` to create your patches, so we get a commit message and your preferred authorship line. For more details on this, and pointers to some helper scripts see the ref guide section on submitting patches
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Thanks Sean Busbey will use the guidelines going forward
        Have added maxCompactionQueueSize and corresponding flush metric, which will get updated every 45 seconds as per the value at that point in time. Let me know if this looks fine.

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Thanks Sean Busbey will use the guidelines going forward Have added maxCompactionQueueSize and corresponding flush metric, which will get updated every 45 seconds as per the value at that point in time. Let me know if this looks fine.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 21s Maven dependency ordering for branch
        +1 mvninstall 3m 6s master passed
        +1 compile 0m 54s master passed
        +1 checkstyle 0m 25s master passed
        +1 mvneclipse 0m 29s master passed
        -1 findbugs 0m 19s hbase-hadoop2-compat in master has 1 extant Findbugs warnings.
        +1 javadoc 0m 44s master passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 3s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvneclipse 0m 28s the patch passed
        -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 hadoopcheck 25m 58s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
        +1 hbaseprotoc 0m 25s the patch passed
        +1 findbugs 2m 38s the patch passed
        +1 javadoc 0m 44s the patch passed
        +1 unit 0m 14s hbase-hadoop-compat in the patch passed.
        +1 unit 0m 20s hbase-hadoop2-compat in the patch passed.
        -1 unit 80m 7s hbase-server in the patch failed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        123m 18s



        Reason Tests
        Timed out junit tests org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
          org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
          org.apache.hadoop.hbase.master.TestTableLockManager
          org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache



        Subsystem Report/Notes
        Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828822/HBASE-15134.master.001.patch
        JIRA Issue HBASE-15134
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux 543c7d6b9061 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision master / 2597217
        Default Java 1.8.0_101
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/3572/artifact/patchprocess/branch-findbugs-hbase-hadoop2-compat-warnings.html
        whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/3572/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/3572/artifact/patchprocess/patch-unit-hbase-server.txt
        unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/3572/artifact/patchprocess/patch-unit-hbase-server.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3572/testReport/
        modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3572/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 3m 6s master passed +1 compile 0m 54s master passed +1 checkstyle 0m 25s master passed +1 mvneclipse 0m 29s master passed -1 findbugs 0m 19s hbase-hadoop2-compat in master has 1 extant Findbugs warnings. +1 javadoc 0m 44s master passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 3s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvneclipse 0m 28s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 hadoopcheck 25m 58s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 hbaseprotoc 0m 25s the patch passed +1 findbugs 2m 38s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 0m 14s hbase-hadoop-compat in the patch passed. +1 unit 0m 20s hbase-hadoop2-compat in the patch passed. -1 unit 80m 7s hbase-server in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 123m 18s Reason Tests Timed out junit tests org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint   org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures   org.apache.hadoop.hbase.master.TestTableLockManager   org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828822/HBASE-15134.master.001.patch JIRA Issue HBASE-15134 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 543c7d6b9061 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 2597217 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/3572/artifact/patchprocess/branch-findbugs-hbase-hadoop2-compat-warnings.html whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/3572/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/3572/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/3572/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3572/testReport/ modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3572/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Fixing whitespace errors and getting another QA

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Fixing whitespace errors and getting another QA
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 13s Maven dependency ordering for branch
        +1 mvninstall 3m 8s master passed
        +1 compile 0m 54s master passed
        +1 checkstyle 0m 26s master passed
        +1 mvneclipse 0m 33s master passed
        -1 findbugs 0m 21s hbase-hadoop2-compat in master has 1 extant Findbugs warnings.
        +1 javadoc 0m 43s master passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 1s the patch passed
        +1 compile 0m 50s the patch passed
        +1 javac 0m 50s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvneclipse 0m 30s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 26m 40s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
        +1 hbaseprotoc 0m 27s the patch passed
        +1 findbugs 2m 46s the patch passed
        +1 javadoc 0m 53s the patch passed
        +1 unit 0m 15s hbase-hadoop-compat in the patch passed.
        +1 unit 0m 19s hbase-hadoop2-compat in the patch passed.
        -1 unit 89m 31s hbase-server in the patch failed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        133m 29s



        Reason Tests
        Failed junit tests hadoop.hbase.regionserver.TestHRegion
        Timed out junit tests org.apache.hadoop.hbase.client.TestFromClientSide
          org.apache.hadoop.hbase.client.TestScannerTimeout
          org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas
          org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient
          org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence



        Subsystem Report/Notes
        Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828829/HBASE-15134.master.002.patch
        JIRA Issue HBASE-15134
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux 7535a27e61f8 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision master / 2597217
        Default Java 1.8.0_101
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/3573/artifact/patchprocess/branch-findbugs-hbase-hadoop2-compat-warnings.html
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/3573/artifact/patchprocess/patch-unit-hbase-server.txt
        unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/3573/artifact/patchprocess/patch-unit-hbase-server.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3573/testReport/
        modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3573/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 3m 8s master passed +1 compile 0m 54s master passed +1 checkstyle 0m 26s master passed +1 mvneclipse 0m 33s master passed -1 findbugs 0m 21s hbase-hadoop2-compat in master has 1 extant Findbugs warnings. +1 javadoc 0m 43s master passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 1s the patch passed +1 compile 0m 50s the patch passed +1 javac 0m 50s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 26m 40s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 hbaseprotoc 0m 27s the patch passed +1 findbugs 2m 46s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 0m 15s hbase-hadoop-compat in the patch passed. +1 unit 0m 19s hbase-hadoop2-compat in the patch passed. -1 unit 89m 31s hbase-server in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 133m 29s Reason Tests Failed junit tests hadoop.hbase.regionserver.TestHRegion Timed out junit tests org.apache.hadoop.hbase.client.TestFromClientSide   org.apache.hadoop.hbase.client.TestScannerTimeout   org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas   org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient   org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828829/HBASE-15134.master.002.patch JIRA Issue HBASE-15134 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 7535a27e61f8 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 2597217 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/3573/artifact/patchprocess/branch-findbugs-hbase-hadoop2-compat-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/3573/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/3573/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/3573/testReport/ modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/3573/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Test HRegion passes reliably for me locally. As for the other timed out tests, i see them timing out on other builds too (https://builds.apache.org/job/PreCommit-HBASE-Build/3593/console , build 3592 etc.)

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Test HRegion passes reliably for me locally. As for the other timed out tests, i see them timing out on other builds too ( https://builds.apache.org/job/PreCommit-HBASE-Build/3593/console , build 3592 etc.)
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Sean Busbey Anoop Sam John Do have a look when you get time. Woukd appreciate any comments. Thanks.

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Sean Busbey Anoop Sam John Do have a look when you get time. Woukd appreciate any comments. Thanks.
        Hide
        stack stack added a comment -

        +1

        Let me try it.

        Show
        stack stack added a comment - +1 Let me try it.
        Hide
        stack stack added a comment -

        I tried this. It works. Do we want to have these extra metrics per region?

        Show
        stack stack added a comment - I tried this. It works. Do we want to have these extra metrics per region?
        Hide
        busbey Sean Busbey added a comment -

        Sounds good to me.

        Show
        busbey Sean Busbey added a comment - Sounds good to me.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Thanks Sean Busbey stack . Since master has changed a bit after the patch, let me rebase/test on the latest branches and get back on this. Also Andrew Purtell would we like to have this in branch-1.4 ?

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Thanks Sean Busbey stack . Since master has changed a bit after the patch, let me rebase/test on the latest branches and get back on this. Also Andrew Purtell would we like to have this in branch-1.4 ?
        Hide
        apurtell Andrew Purtell added a comment -

        Yes please.

        Please consider branch-1.4 open for commits. Anything that goes into branch-1, please put into branch-1.4 too, until I ask for a freeze later.

        Show
        apurtell Andrew Purtell added a comment - Yes please. Please consider branch-1.4 open for commits. Anything that goes into branch-1, please put into branch-1.4 too, until I ask for a freeze later.
        Hide
        stack stack added a comment -

        Do we want to have these extra metrics per region?

        I should have said why I ask; to me it seems like these are very particular metrics to carry around on a per region basis. The danger is that they may be perceived as clutter and of little use to general operators. I was looking for some discussion/opinions on whether my perception was off or not. Thanks.

        Show
        stack stack added a comment - Do we want to have these extra metrics per region? I should have said why I ask; to me it seems like these are very particular metrics to carry around on a per region basis. The danger is that they may be perceived as clutter and of little use to general operators. I was looking for some discussion/opinions on whether my perception was off or not. Thanks.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        > The danger is that they may be perceived as clutter and of little use to general operators

        I agree, for general operators these won't be very useful on a day to day basis, but would come handy when analyzing issues related to load/specific use case perf degradations etc. IMO they'd be useful addition, not having these would then mean going to the logs and grepping the log lines to find these out. However we can drop these if they add too much of an overhead.

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - > The danger is that they may be perceived as clutter and of little use to general operators I agree, for general operators these won't be very useful on a day to day basis, but would come handy when analyzing issues related to load/specific use case perf degradations etc. IMO they'd be useful addition, not having these would then mean going to the logs and grepping the log lines to find these out. However we can drop these if they add too much of an overhead.
        Hide
        apurtell Andrew Purtell added a comment -

        I think per region flush and compaction metrics are useful. They indicate IO load on the region that might be hard to detect through other means. Op counters don't tell a story about the store level consequences of client activity like flushes and compactions do. FWIW

        If we're going to commit this, I'd like to see it brought back at least as far as branch-1.4. Thanks.

        Show
        apurtell Andrew Purtell added a comment - I think per region flush and compaction metrics are useful. They indicate IO load on the region that might be hard to detect through other means. Op counters don't tell a story about the store level consequences of client activity like flushes and compactions do. FWIW If we're going to commit this, I'd like to see it brought back at least as far as branch-1.4. Thanks.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Rebased on latest master. Getting QA run.

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Rebased on latest master. Getting QA run.
        Hide
        stack stack added a comment -

        Sounds good. Will commit. Lets see what the hadoopqa run says... Thanks Abhishek Singh Chouhan

        Show
        stack stack added a comment - Sounds good. Will commit. Lets see what the hadoopqa run says... Thanks Abhishek Singh Chouhan
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 3m 17s master passed
        +1 compile 0m 59s master passed
        +1 checkstyle 0m 25s master passed
        +1 mvneclipse 0m 34s master passed
        +1 findbugs 3m 25s master passed
        +1 javadoc 0m 48s master passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 5s the patch passed
        +1 compile 0m 58s the patch passed
        +1 javac 0m 58s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvneclipse 0m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 29m 13s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
        +1 findbugs 3m 45s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 0m 21s hbase-hadoop-compat in the patch passed.
        +1 unit 0m 27s hbase-hadoop2-compat in the patch passed.
        +1 unit 120m 31s hbase-server in the patch passed.
        +1 asflicense 0m 46s The patch does not generate ASF License warnings.
        169m 55s



        Subsystem Report/Notes
        Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1
        JIRA Issue HBASE-15134
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879178/HBASE-15134.master.003.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux 286b024bb5be 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision master / a649afe
        Default Java 1.8.0_131
        findbugs v3.1.0-RC3
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7813/testReport/
        modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7813/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 3m 17s master passed +1 compile 0m 59s master passed +1 checkstyle 0m 25s master passed +1 mvneclipse 0m 34s master passed +1 findbugs 3m 25s master passed +1 javadoc 0m 48s master passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 5s the patch passed +1 compile 0m 58s the patch passed +1 javac 0m 58s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 29m 13s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 3m 45s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 0m 21s hbase-hadoop-compat in the patch passed. +1 unit 0m 27s hbase-hadoop2-compat in the patch passed. +1 unit 120m 31s hbase-server in the patch passed. +1 asflicense 0m 46s The patch does not generate ASF License warnings. 169m 55s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 JIRA Issue HBASE-15134 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879178/HBASE-15134.master.003.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 286b024bb5be 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / a649afe Default Java 1.8.0_131 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7813/testReport/ modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7813/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 1m 13s Maven dependency ordering for branch
        +1 mvninstall 6m 0s branch-1 passed
        +1 compile 0m 53s branch-1 passed
        +1 checkstyle 0m 31s branch-1 passed
        +1 mvneclipse 0m 44s branch-1 passed
        -1 findbugs 0m 20s hbase-hadoop2-compat in branch-1 has 1 extant Findbugs warnings.
        +1 javadoc 0m 50s branch-1 passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 1s the patch passed
        +1 compile 0m 57s the patch passed
        +1 javac 0m 57s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvneclipse 0m 32s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 hadoopcheck 15m 29s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
        +1 findbugs 2m 45s the patch passed
        +1 javadoc 0m 54s the patch passed
        +1 unit 0m 20s hbase-hadoop-compat in the patch passed.
        +1 unit 0m 24s hbase-hadoop2-compat in the patch passed.
        -1 unit 122m 38s hbase-server in the patch failed.
        +1 asflicense 0m 47s The patch does not generate ASF License warnings.
        159m 59s



        Reason Tests
        Failed junit tests hadoop.hbase.mapred.TestTableSnapshotInputFormat
          hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
          hadoop.hbase.replication.TestReplicationKillSlaveRS
          hadoop.hbase.client.TestClientScannerRPCTimeout
          hadoop.hbase.TestZooKeeper
        Timed out junit tests org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes
          org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions



        Subsystem Report/Notes
        Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1
        JIRA Issue HBASE-15134
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879230/HBASE-15134.branch-1.001.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux 9262aa6e8e97 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
        git revision branch-1 / aca8a12
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7817/artifact/patchprocess/branch-findbugs-hbase-hadoop2-compat-warnings.html
        whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/7817/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/7817/artifact/patchprocess/patch-unit-hbase-server.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7817/testReport/
        modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7817/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 13s Maven dependency ordering for branch +1 mvninstall 6m 0s branch-1 passed +1 compile 0m 53s branch-1 passed +1 checkstyle 0m 31s branch-1 passed +1 mvneclipse 0m 44s branch-1 passed -1 findbugs 0m 20s hbase-hadoop2-compat in branch-1 has 1 extant Findbugs warnings. +1 javadoc 0m 50s branch-1 passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 1s the patch passed +1 compile 0m 57s the patch passed +1 javac 0m 57s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvneclipse 0m 32s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 hadoopcheck 15m 29s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 2m 45s the patch passed +1 javadoc 0m 54s the patch passed +1 unit 0m 20s hbase-hadoop-compat in the patch passed. +1 unit 0m 24s hbase-hadoop2-compat in the patch passed. -1 unit 122m 38s hbase-server in the patch failed. +1 asflicense 0m 47s The patch does not generate ASF License warnings. 159m 59s Reason Tests Failed junit tests hadoop.hbase.mapred.TestTableSnapshotInputFormat   hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   hadoop.hbase.replication.TestReplicationKillSlaveRS   hadoop.hbase.client.TestClientScannerRPCTimeout   hadoop.hbase.TestZooKeeper Timed out junit tests org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes   org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions Subsystem Report/Notes Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 JIRA Issue HBASE-15134 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879230/HBASE-15134.branch-1.001.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 9262aa6e8e97 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision branch-1 / aca8a12 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/7817/artifact/patchprocess/branch-findbugs-hbase-hadoop2-compat-warnings.html whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/7817/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/7817/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/7817/testReport/ modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7817/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        apurtell Andrew Purtell added a comment -

        +1
        Findbugs and test results aren't germane to this patch

        Show
        apurtell Andrew Purtell added a comment - +1 Findbugs and test results aren't germane to this patch
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Fixed trailing whitespaces.

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Fixed trailing whitespaces.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment - - edited

        Pushed to branch-1.4+. Thanks for the reviews !!

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - - edited Pushed to branch-1.4+. Thanks for the reviews !!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 8s HBASE-15134 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help.



        Subsystem Report/Notes
        JIRA Issue HBASE-15134
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879310/HBASE-15134.branch-1.001.patch
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7823/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 8s HBASE-15134 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. Subsystem Report/Notes JIRA Issue HBASE-15134 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879310/HBASE-15134.branch-1.001.patch Console output https://builds.apache.org/job/PreCommit-HBASE-Build/7823/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        abhishek.chouhan Abhishek Singh Chouhan added a comment -

        Hadoop QA ran after the patch with whitespace fix was reattached and pushed to branch hence errored out.

        Show
        abhishek.chouhan Abhishek Singh Chouhan added a comment - Hadoop QA ran after the patch with whitespace fix was reattached and pushed to branch hence errored out.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-1.4 #826 (See https://builds.apache.org/job/HBase-1.4/826/)
        HBASE-15134 Add visibility into Flush and Compaction queues (achouhan: rev 92780371080a341d0b6f98307a0ea176db327c5a)

        • (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java
        • (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
        • (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-1.4 #826 (See https://builds.apache.org/job/HBase-1.4/826/ ) HBASE-15134 Add visibility into Flush and Compaction queues (achouhan: rev 92780371080a341d0b6f98307a0ea176db327c5a) (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-2.0 #248 (See https://builds.apache.org/job/HBase-2.0/248/)
        HBASE-15134 Add visibility into Flush and Compaction queues (achouhan: rev 12b9a151e6338297b253ca2e005eda22b1f2da4e)

        • (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java
        • (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
        • (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
        • (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #248 (See https://builds.apache.org/job/HBase-2.0/248/ ) HBASE-15134 Add visibility into Flush and Compaction queues (achouhan: rev 12b9a151e6338297b253ca2e005eda22b1f2da4e) (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3449 (See https://builds.apache.org/job/HBase-Trunk_matrix/3449/)
        HBASE-15134 Add visibility into Flush and Compaction queues (achouhan: rev 2d06a06ba4bbd2f64e28be5973eb1d447114bedc)

        • (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java
        • (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java
        • (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3449 (See https://builds.apache.org/job/HBase-Trunk_matrix/3449/ ) HBASE-15134 Add visibility into Flush and Compaction queues (achouhan: rev 2d06a06ba4bbd2f64e28be5973eb1d447114bedc) (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See https://builds.apache.org/job/HBASE-14070.HLC/233/)
        HBASE-15134 Add visibility into Flush and Compaction queues (achouhan: rev 2d06a06ba4bbd2f64e28be5973eb1d447114bedc)

        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java
        • (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java
        • (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
        • (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java
        • (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBASE-14070 .HLC #233 (See https://builds.apache.org/job/HBASE-14070.HLC/233/ ) HBASE-15134 Add visibility into Flush and Compaction queues (achouhan: rev 2d06a06ba4bbd2f64e28be5973eb1d447114bedc) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java (edit) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java

          People

          • Assignee:
            abhishek.chouhan Abhishek Singh Chouhan
            Reporter:
            eclark Elliott Clark
          • Votes:
            1 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development