Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15093

Replication can report incorrect size of log queue for the global source when multiwal is enabled

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.2.1, 2.0.0
    • Fix Version/s: 1.3.0, 2.0.0
    • Component/s: Replication
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Replication can report incorrect size for the size of log queue for the global source when multiwal is enabled. This happens because the method MetricsSource#setSizeofLogQueue performs non-trivial operations in a multithreaded world, even though it is not synchronized.

      We can simply divide MetricsSource#setSizeofLogQueue into MetricsSource#incrSizeofLogQueue and MetricsSource#decrSizeofLogQueue. Not sure why we are currently directly setting the size instead of incrementing/decrementing it.

        Attachments

        1. HBASE-15093-V0.patch
          8 kB
          Ashu Pachauri
        2. HBASE-15093-V1.patch
          9 kB
          Ashu Pachauri
        3. HBASE-15093-V1.patch
          9 kB
          Ted Yu
        4. HBASE-15093-V2.patch
          8 kB
          Ashu Pachauri

          Issue Links

            Activity

              People

              • Assignee:
                ashu210890 Ashu Pachauri
                Reporter:
                ashu210890 Ashu Pachauri
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: