[HBASE-15093] Replication can report incorrect size of log queue for the global source when multiwal is enabled

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2.0, 1.2.1, 2.0.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: Replication
• Hadoop Flags: Reviewed
• Assignee: Ashu Pachauri
• Reporter: Ashu Pachauri
• Created: 12/Jan/16 23:41
• Updated: 09/Nov/17 00:39
• Resolved: 11/Apr/16 15:27

Description

Replication can report incorrect size for the size of log queue for the global source when multiwal is enabled. This happens because the method MetricsSource#setSizeofLogQueue performs non-trivial operations in a multithreaded world, even though it is not synchronized.

We can simply divide MetricsSource#setSizeofLogQueue into MetricsSource#incrSizeofLogQueue and MetricsSource#decrSizeofLogQueue. Not sure why we are currently directly setting the size instead of incrementing/decrementing it.

Issue Links

• is related to: HBASE-14457 Umbrella: Improve Multiple WAL for production usage