Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15052

Use EnvironmentEdgeManager in ReplicationSource

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 1.2.0, 1.1.2, 1.0.3, 0.98.16.1, 2.0.0
    • 1.2.0, 1.0.3, 1.1.3, 0.98.17, 2.0.0
    • Replication
    • None

    Description

      ReplicationSource is passing System.currentTimeMillis() to MetricsSource.setAgeOfLastShippedOp() which is subtracting that from EnvironmentEdgeManager.currentTime().

      // if there was nothing to ship and it's not an error
      // set "ageOfLastShippedOp" to <now> to indicate that we're current
      metrics.setAgeOfLastShippedOp(System.currentTimeMillis(), walGroupId);
      
      public void setAgeOfLastShippedOp(long timestamp, String walGroup) {
          long age = EnvironmentEdgeManager.currentTime() - timestamp;
      

      we should just use EnvironmentEdgeManager.currentTime() in ReplicationSource

      Attachments

        1. HBASE-15052-v00.patch
          1 kB
          Matteo Bertozzi
        2. HBASE-15052-v0.patch
          1 kB
          Matteo Bertozzi

        Activity

          People

            mbertozzi Matteo Bertozzi
            mbertozzi Matteo Bertozzi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: