Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15052

Use EnvironmentEdgeManager in ReplicationSource

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.1.2, 1.0.3, 0.98.16.1, 2.0.0
    • Fix Version/s: 1.2.0, 1.0.3, 1.1.3, 0.98.17, 2.0.0
    • Component/s: Replication
    • Labels:
      None

      Description

      ReplicationSource is passing System.currentTimeMillis() to MetricsSource.setAgeOfLastShippedOp() which is subtracting that from EnvironmentEdgeManager.currentTime().

      // if there was nothing to ship and it's not an error
      // set "ageOfLastShippedOp" to <now> to indicate that we're current
      metrics.setAgeOfLastShippedOp(System.currentTimeMillis(), walGroupId);
      
      public void setAgeOfLastShippedOp(long timestamp, String walGroup) {
          long age = EnvironmentEdgeManager.currentTime() - timestamp;
      

      we should just use EnvironmentEdgeManager.currentTime() in ReplicationSource

        Attachments

        1. HBASE-15052-v0.patch
          1 kB
          Matteo Bertozzi
        2. HBASE-15052-v00.patch
          1 kB
          Matteo Bertozzi

          Activity

            People

            • Assignee:
              mbertozzi Matteo Bertozzi
              Reporter:
              mbertozzi Matteo Bertozzi
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: