[HBASE-14989] Implementation of Mutation.getWriteToWAL() is backwards

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.17
• Component/s: Client
• Hadoop Flags: Reviewed
• Assignee: Enis Soztutar
• Reporter: James R. Taylor
• Created: 16/Dec/15 02:35
• Updated: 27/Jan/16 15:28
• Resolved: 17/Dec/15 20:31

Description

The implementation of the deprecated getWriteToWAL is backwards. It should return true if this.durability == Durability.SYNC_WAL:

/**
   * @deprecated Use {@link #getDurability()} instead.
   * @return true if edits should be applied to WAL, false if not
   */
  @Deprecated
  public boolean getWriteToWAL() {
    return this.durability == Durability.SKIP_WAL;
  }

For example, if mutation.durability is Durability.SYNC_WAL and the following code is called clonedMutation.setWriteToWAL(mutation.getWriteToWAL()), it will disable writing to the WAL for clonedMutation.