[HBASE-14936] CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.2
• Fix Version/s: 1.2.0, 1.3.0, 1.0.3, 1.1.3, 2.0.0
• Component/s: BlockCache
• Assignee: Jianwei Cui
• Reporter: Jianwei Cui
• Created: 07/Dec/15 09:54
• Updated: 27/Jan/16 15:29
• Resolved: 14/Dec/15 10:56

Description

It seems CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() as

public void rollMetricsPeriod() {
  lruCacheStats.rollMetricsPeriod();
  bucketCacheStats.rollMetricsPeriod();
}

otherwise, CombinedBlockCache.getHitRatioPastNPeriods() and CombinedBlockCache.getHitCachingRatioPastNPeriods() will always return 0.