Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14936

CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod()

    XMLWordPrintableJSON

    Details

      Description

      It seems CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() as

      public void rollMetricsPeriod() {
        lruCacheStats.rollMetricsPeriod();
        bucketCacheStats.rollMetricsPeriod();
      }
      

      otherwise, CombinedBlockCache.getHitRatioPastNPeriods() and CombinedBlockCache.getHitCachingRatioPastNPeriods() will always return 0.

        Attachments

        1. HBASE-14936-trunk.patch
          0.7 kB
          Jianwei Cui
        2. HBASE-14936-trunk-v1.patch
          7 kB
          Jianwei Cui
        3. HBASE-14936-trunk-v2.patch
          8 kB
          Jianwei Cui
        4. HBASE-14936-branch-1.0-1.1.patch
          7 kB
          Jianwei Cui
        5. HBASE-14936-branch-1.0-addendum.patch
          1 kB
          Heng Chen

          Activity

            People

            • Assignee:
              cuijianwei Jianwei Cui
              Reporter:
              cuijianwei Jianwei Cui
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: