Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14865

Support passing multiple QOPs to SaslClient/Server via hbase.rpc.protection

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      With this patch, hbase.rpc.protection can now take multiple comma-separate QOP values. Accepted QOP values remain unchanged and are 'authentication', 'integrity', and 'privacy'. Server or client can use this configuration to specify their preference (in decreasing order) while negotiating QOP.
      This feature can be used to upgrade or downgrade QOP in an online cluster without compromising availability (i.e. taking cluster offline). For e.g. to change qop from A to B, typical steps would be:
      "A" --> "B,A" --> rolling restart --> "B" --> rolling restart

      Sidenote: Based on experimentation, server's choice is given higher preference than client's choice. i.e. if server's choices are "A,B,C" and client's choices are "B,C,A", both A and B are acceptable, but A is chosen.
      Show
      With this patch, hbase.rpc.protection can now take multiple comma-separate QOP values. Accepted QOP values remain unchanged and are 'authentication', 'integrity', and 'privacy'. Server or client can use this configuration to specify their preference (in decreasing order) while negotiating QOP. This feature can be used to upgrade or downgrade QOP in an online cluster without compromising availability (i.e. taking cluster offline). For e.g. to change qop from A to B, typical steps would be: "A" --> "B,A" --> rolling restart --> "B" --> rolling restart Sidenote: Based on experimentation, server's choice is given higher preference than client's choice. i.e. if server's choices are "A,B,C" and client's choices are "B,C,A", both A and B are acceptable, but A is chosen.

      Description

      Currently, we can set the value of hbase.rpc.protection to one of authentication/integrity/privacy. It is the used to set javax.security.sasl.qop in SaslUtil.java.
      The problem is, if a cluster wants to switch from one qop to another, it'll have to take a downtime. Rolling upgrade will create a situation where some nodes have old value and some have new, which'll prevent any communication between them. There will be similar issue when clients will try to connect.

      javax.security.sasl.qop can take in a list of QOP in preferences order. So a transition from qop1 to qop2 can be easily done like this
      "qop1" --> "qop2,qop1" --> rolling restart --> "qop2" --> rolling restart

      Need to change hbase.rpc.protection to accept a list too.

      1. 14865-master-v7.patch
        70 kB
        Ted Yu
      2. HBASE-14865-branch-1.patch
        70 kB
        Appy
      3. HBASE-14865-master-v7.patch
        70 kB
        Appy
      4. HBASE-14865-branch-1.2.patch
        70 kB
        Appy
      5. HBASE-14865-branch-1.patch
        70 kB
        Appy
      6. HBASE-14865-master-v6.patch
        70 kB
        Appy
      7. HBASE-14865-master-v5.patch
        71 kB
        Appy
      8. HBASE-14865-master-v4.patch
        71 kB
        Appy
      9. HBASE-14865-master-v3.patch
        70 kB
        Appy
      10. HBASE-14865-master-v2.patch
        71 kB
        Appy
      11. HBASE-14865-master.patch
        67 kB
        Appy

        Issue Links

          Activity

          Hide
          mbertozzi Matteo Bertozzi added a comment -

          yeah, fixes are in 2.6.1 and 2.7.1 and we updated the doc with the supported versions here HBASE-16884

          Show
          mbertozzi Matteo Bertozzi added a comment - yeah, fixes are in 2.6.1 and 2.7.1 and we updated the doc with the supported versions here HBASE-16884
          Hide
          mantonov Mikhail Antonov added a comment -

          So that puts an implicit assumption that 2.0 would only support Hadoop 2.7.0+, right? Just to confirm, based on the Matteo Bertozzi above

          Show
          mantonov Mikhail Antonov added a comment - So that puts an implicit assumption that 2.0 would only support Hadoop 2.7.0+, right? Just to confirm, based on the Matteo Bertozzi above
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.3 #506 (See https://builds.apache.org/job/HBase-1.3/506/)
          Revert "HBASE-14865 Support passing multiple QOPs to SaslClient/Server (stack: rev d965d14a63c1d713b8b85be23f77599431034c5e)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #506 (See https://builds.apache.org/job/HBase-1.3/506/ ) Revert " HBASE-14865 Support passing multiple QOPs to SaslClient/Server (stack: rev d965d14a63c1d713b8b85be23f77599431034c5e) hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.3-IT #451 (See https://builds.apache.org/job/HBase-1.3-IT/451/)
          Revert "HBASE-14865 Support passing multiple QOPs to SaslClient/Server (stack: rev d965d14a63c1d713b8b85be23f77599431034c5e)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.3-IT #451 (See https://builds.apache.org/job/HBase-1.3-IT/451/ ) Revert " HBASE-14865 Support passing multiple QOPs to SaslClient/Server (stack: rev d965d14a63c1d713b8b85be23f77599431034c5e) hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
          Hide
          stack stack added a comment -

          Thanks Matteo Bertozzi Reverted from branch-1. We can come back here if branch-1 ups its hadoop version.

          Resolving again.

          Show
          stack stack added a comment - Thanks Matteo Bertozzi Reverted from branch-1. We can come back here if branch-1 ups its hadoop version. Resolving again.
          Hide
          mbertozzi Matteo Bertozzi added a comment -

          yeah the failure is due to this. but the fix is in HADOOP-10786/HADOOP-11287

          Show
          mbertozzi Matteo Bertozzi added a comment - yeah the failure is due to this. but the fix is in HADOOP-10786 / HADOOP-11287
          Hide
          stack stack added a comment -

          Is this responsible for the fails on branch-1 that I am seeing here in SecureIPC tests?

          https://builds.apache.org/view/H-L/view/HBase/job/HBase-1.3/501/

          I can revert and see if it fixes the problem?

          Reopened this issue meantime. Close if I have it wrong.

          Show
          stack stack added a comment - Is this responsible for the fails on branch-1 that I am seeing here in SecureIPC tests? https://builds.apache.org/view/H-L/view/HBase/job/HBase-1.3/501/ I can revert and see if it fixes the problem? Reopened this issue meantime. Close if I have it wrong.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.3-IT #444 (See https://builds.apache.org/job/HBase-1.3-IT/444/)
          HBASE-14865 Support passing multiple QOPs to SaslClient/Server via (tedyu: rev e76a2e4e6d91deee250d180b75b890f743da4bf0)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.3-IT #444 (See https://builds.apache.org/job/HBase-1.3-IT/444/ ) HBASE-14865 Support passing multiple QOPs to SaslClient/Server via (tedyu: rev e76a2e4e6d91deee250d180b75b890f743da4bf0) hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.3 #501 (See https://builds.apache.org/job/HBase-1.3/501/)
          HBASE-14865 Support passing multiple QOPs to SaslClient/Server via (tedyu: rev e76a2e4e6d91deee250d180b75b890f743da4bf0)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #501 (See https://builds.apache.org/job/HBase-1.3/501/ ) HBASE-14865 Support passing multiple QOPs to SaslClient/Server via (tedyu: rev e76a2e4e6d91deee250d180b75b890f743da4bf0) hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          Hide
          appy Appy added a comment -

          Em, there is one attached already (HBASE-14865-branch-1.patch, 2nd Dec, sorry for not adding patch version to the name). I was able to cleanly merge it with latest branch-1 using git apply just before I posted the request. Can you please give that patch a try. Thanks Ted Yu.

          Show
          appy Appy added a comment - Em, there is one attached already ( HBASE-14865 -branch-1.patch, 2nd Dec, sorry for not adding patch version to the name). I was able to cleanly merge it with latest branch-1 using git apply just before I posted the request. Can you please give that patch a try. Thanks Ted Yu .
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Would be more than happy to.
          Can you attach patch for branch-1 ?

          -rw-r--r--  1 tyu  staff  13396 Jan 19 12:13 ./hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java.rej
          -rw-r--r--  1 tyu  staff  9254 Jan 19 12:13 ./hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java.rej
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - Would be more than happy to. Can you attach patch for branch-1 ? -rw-r--r-- 1 tyu staff 13396 Jan 19 12:13 ./hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java.rej -rw-r--r-- 1 tyu staff 9254 Jan 19 12:13 ./hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java.rej
          Hide
          appy Appy added a comment -

          Ted Yu Please commit it to branch-1 too. Thanks.

          Show
          appy Appy added a comment - Ted Yu Please commit it to branch-1 too. Thanks.
          Hide
          appy Appy added a comment -

          btw, looks like a good enough feature to backport to branch-1 too.

          Show
          appy Appy added a comment - btw, looks like a good enough feature to backport to branch-1 too.
          Hide
          appy Appy added a comment -

          Thanks Matteo Bertozzi and Ted Yu for reviewing.

          Show
          appy Appy added a comment - Thanks Matteo Bertozzi and Ted Yu for reviewing.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-Trunk_matrix #633 (See https://builds.apache.org/job/HBase-Trunk_matrix/633/)
          HBASE-14865 Support passing multiple QOPs to SaslClient/Server via (tedyu: rev 4ac8d4ce610a107112acb6aa070157691c022e90)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-Trunk_matrix #633 (See https://builds.apache.org/job/HBase-Trunk_matrix/633/ ) HBASE-14865 Support passing multiple QOPs to SaslClient/Server via (tedyu: rev 4ac8d4ce610a107112acb6aa070157691c022e90) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Integrated to master

          Mind adding release notes ?

          Thanks

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Integrated to master Mind adding release notes ? Thanks
          Hide
          appy Appy added a comment -

          Cool, ready for commit.

          Show
          appy Appy added a comment - Cool, ready for commit.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          I ran the test locally again and it passed:

          Running org.apache.hadoop.hbase.security.TestSecureIPC
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.363 sec - in org.apache.hadoop.hbase.security.TestSecureIPC
          

          +1 from me.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - I ran the test locally again and it passed: Running org.apache.hadoop.hbase.security.TestSecureIPC Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.363 sec - in org.apache.hadoop.hbase.security.TestSecureIPC +1 from me.
          Hide
          appy Appy added a comment -

          Ted Yu I can't reproduce your error. Here are my run details. Anything am missing?

          root @ ~  → java -version
          java version "1.7.0_60"
          Java(TM) SE Runtime Environment (build 1.7.0_60-b19)
          Java HotSpot(TM) 64-Bit Server VM (build 24.60-b09, mixed mode)
          
          root @ ~  → cat /proc/version
          Linux version 3.13.0-24-generic (buildd@panlong) (gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) ) #46-Ubuntu SMP Thu Apr 10 19:11:08 UTC 2014
          
          
          # With master branch
          
          root @ ~/git/hbase  (master) → git status
          On branch master
          Your branch is ahead of 'origin/master' by 1 commit.
            (use "git push" to publish your local commits)
          
          root @ ~/git/hbase  (master) → git log | head -n 10
          commit d2860e642743f302cc5321fdd1bd05f5d5de930f
          Author: root <root@sasl.vpc.cloudera.com>
          Date:   Thu Jan 14 14:10:12 2016 -0800
          
              .
          
          commit ae7cc0c8487dd10f72c64c898ddfec6f2ceca643
          Author: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
          Date:   Thu Jan 14 13:45:17 2016 -0800
          
          root @ ~/git/hbase  (master) → mvn clean test -Dtest=TestSecureIPC
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.hbase.security.TestSecureIPC
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.009 sec - in org.apache.hadoop.hbase.security.TestSecureIPC
          
          Results :
          
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
          
          # With branch-1
          
          root @ ~/git/hbase  (branch-1) → git status
          On branch branch-1
          Your branch is ahead of 'origin/branch-1' by 1 commit.
            (use "git push" to publish your local commits)
          
          root @ ~/git/hbase  (branch-1) → git log | head -n 20
          commit cd86d1b4f9dac4227e23e6ef43dd04b644112379
          Author: root <root@sasl.vpc.cloudera.com>
          Date:   Thu Jan 14 14:47:38 2016 -0800
          
              HBASE-14865 Support passing multiple QOPs to
               SaslClient/Server via hbase.rpc.protection - Added tests to check for rpc
               success/failure when server and client configuration matches/not-matches. -
               Added TestSaslUtil - Remove static (global) SaslUtil.SASL_PROPS. Was
               impossible to unittest with different settings for server and client as they
               ended up sharing it. - Moved TestHBaseSaslRpcClient from hbase-server to
               hbase-client. - Removed not helpful javadocs. Most were just rewording of
               function/parameter name. (Apekshit)
          
          commit f8427aba2bed9aef3fe9473dc9b2ff2bd60229e3
          Author: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
          Date:   Thu Jan 14 13:45:17 2016 -0800
          
              HBASE-15105 Procedure V2 - Procedure Queue with Namespaces
          
          root @ ~/git/hbase  (branch-1) → mvn clean test -Dtest=TestSecureIPC
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.hbase.security.TestSecureIPC
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.955 sec - in org.apache.hadoop.hbase.security.TestSecureIPC
          
          Results :
          
          Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
          
          
          Show
          appy Appy added a comment - Ted Yu I can't reproduce your error. Here are my run details. Anything am missing? root @ ~ → java -version java version "1.7.0_60" Java(TM) SE Runtime Environment (build 1.7.0_60-b19) Java HotSpot(TM) 64-Bit Server VM (build 24.60-b09, mixed mode) root @ ~ → cat /proc/version Linux version 3.13.0-24-generic (buildd@panlong) (gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) ) #46-Ubuntu SMP Thu Apr 10 19:11:08 UTC 2014 # With master branch root @ ~/git/hbase (master) → git status On branch master Your branch is ahead of 'origin/master' by 1 commit. (use "git push" to publish your local commits) root @ ~/git/hbase (master) → git log | head -n 10 commit d2860e642743f302cc5321fdd1bd05f5d5de930f Author: root <root@sasl.vpc.cloudera.com> Date: Thu Jan 14 14:10:12 2016 -0800 . commit ae7cc0c8487dd10f72c64c898ddfec6f2ceca643 Author: Matteo Bertozzi <matteo.bertozzi@cloudera.com> Date: Thu Jan 14 13:45:17 2016 -0800 root @ ~/git/hbase (master) → mvn clean test -Dtest=TestSecureIPC ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.security.TestSecureIPC Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.009 sec - in org.apache.hadoop.hbase.security.TestSecureIPC Results : Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 # With branch-1 root @ ~/git/hbase (branch-1) → git status On branch branch-1 Your branch is ahead of 'origin/branch-1' by 1 commit. (use "git push" to publish your local commits) root @ ~/git/hbase (branch-1) → git log | head -n 20 commit cd86d1b4f9dac4227e23e6ef43dd04b644112379 Author: root <root@sasl.vpc.cloudera.com> Date: Thu Jan 14 14:47:38 2016 -0800 HBASE-14865 Support passing multiple QOPs to SaslClient/Server via hbase.rpc.protection - Added tests to check for rpc success/failure when server and client configuration matches/not-matches. - Added TestSaslUtil - Remove static (global) SaslUtil.SASL_PROPS. Was impossible to unittest with different settings for server and client as they ended up sharing it. - Moved TestHBaseSaslRpcClient from hbase-server to hbase-client. - Removed not helpful javadocs. Most were just rewording of function/parameter name. (Apekshit) commit f8427aba2bed9aef3fe9473dc9b2ff2bd60229e3 Author: Matteo Bertozzi <matteo.bertozzi@cloudera.com> Date: Thu Jan 14 13:45:17 2016 -0800 HBASE-15105 Procedure V2 - Procedure Queue with Namespaces root @ ~/git/hbase (branch-1) → mvn clean test -Dtest=TestSecureIPC ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.security.TestSecureIPC Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.955 sec - in org.apache.hadoop.hbase.security.TestSecureIPC Results : Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
          Hide
          appy Appy added a comment -

          Ted Yu Seems like unlike failures seen by Matteo, your's isn't dependent on hadoop.

          Just to make it clear for future reference, there are two separate failures here:
          1. 'No valid credentials' error. This has been debugged and is explained above.

          Expected: (an instance of javax.security.sasl.SaslException and exception with message a string containing "No common protection layer between client and server")
               but: an instance of javax.security.sasl.SaslException <GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)> is a org.ietf.jgss.GSSException
          Stacktrace was: GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)
          

          2. 'Null realm name': Will work on it next.

          testRpcCallWithEnabledKerberosSaslAuth(org.apache.hadoop.hbase.security.TestSecureIPC)  Time elapsed: 0.049 sec  <<< ERROR!
          java.io.IOException: Login failure for hbase/localhost@EXAMPLE.COM from keytab /Users/tyu/trunk/hbase-server/target/test-data/76d0c754-8dca-4c88-9933-b5a77646a750/keytab: javax.security.auth.login.LoginException: Null realm name (601)
          
          Show
          appy Appy added a comment - Ted Yu Seems like unlike failures seen by Matteo, your's isn't dependent on hadoop. Just to make it clear for future reference, there are two separate failures here: 1. 'No valid credentials' error. This has been debugged and is explained above . Expected: (an instance of javax.security.sasl.SaslException and exception with message a string containing "No common protection layer between client and server") but: an instance of javax.security.sasl.SaslException <GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)> is a org.ietf.jgss.GSSException Stacktrace was: GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt) 2. 'Null realm name': Will work on it next. testRpcCallWithEnabledKerberosSaslAuth(org.apache.hadoop.hbase.security.TestSecureIPC) Time elapsed: 0.049 sec <<< ERROR! java.io.IOException: Login failure for hbase/localhost@EXAMPLE.COM from keytab /Users/tyu/trunk/hbase-server/target/test-data/76d0c754-8dca-4c88-9933-b5a77646a750/keytab: javax.security.auth.login.LoginException: Null realm name (601)
          Hide
          appy Appy added a comment -

          Anyone knows what to do of "findbugs"?
          There are warnings from files which this patch doesn't even touch.

          Show
          appy Appy added a comment - Anyone knows what to do of "findbugs"? There are warnings from files which this patch doesn't even touch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
          +1 mvninstall 2m 20s master passed
          +1 compile 1m 0s master passed with JDK v1.8.0
          +1 compile 0m 49s master passed with JDK v1.7.0_79
          +1 checkstyle 6m 16s master passed
          +1 mvneclipse 0m 24s master passed
          -1 findbugs 0m 55s hbase-client in master has 13 extant Findbugs warnings.
          -1 findbugs 1m 51s hbase-server in master has 83 extant Findbugs warnings.
          +1 javadoc 0m 51s master passed with JDK v1.8.0
          +1 javadoc 0m 51s master passed with JDK v1.7.0_79
          +1 mvninstall 1m 3s the patch passed
          +1 compile 1m 4s the patch passed with JDK v1.8.0
          +1 javac 1m 4s the patch passed
          +1 compile 0m 50s the patch passed with JDK v1.7.0_79
          +1 javac 0m 50s the patch passed
          +1 checkstyle 6m 17s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 20m 57s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 findbugs 3m 7s the patch passed
          +1 javadoc 0m 50s the patch passed with JDK v1.8.0
          +1 javadoc 0m 48s the patch passed with JDK v1.7.0_79
          +1 unit 0m 53s hbase-client in the patch passed with JDK v1.8.0.
          +1 unit 82m 22s hbase-server in the patch passed with JDK v1.8.0.
          +1 unit 0m 56s hbase-client in the patch passed with JDK v1.7.0_79.
          +1 unit 80m 41s hbase-server in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          216m 32s



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782205/14865-master-v7.patch
          JIRA Issue HBASE-14865
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / c8b9754
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/110/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/110/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/110/testReport/
          modules C: hbase-client hbase-server U: .
          Max memory used 191MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/110/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. +1 mvninstall 2m 20s master passed +1 compile 1m 0s master passed with JDK v1.8.0 +1 compile 0m 49s master passed with JDK v1.7.0_79 +1 checkstyle 6m 16s master passed +1 mvneclipse 0m 24s master passed -1 findbugs 0m 55s hbase-client in master has 13 extant Findbugs warnings. -1 findbugs 1m 51s hbase-server in master has 83 extant Findbugs warnings. +1 javadoc 0m 51s master passed with JDK v1.8.0 +1 javadoc 0m 51s master passed with JDK v1.7.0_79 +1 mvninstall 1m 3s the patch passed +1 compile 1m 4s the patch passed with JDK v1.8.0 +1 javac 1m 4s the patch passed +1 compile 0m 50s the patch passed with JDK v1.7.0_79 +1 javac 0m 50s the patch passed +1 checkstyle 6m 17s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 20m 57s Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 findbugs 3m 7s the patch passed +1 javadoc 0m 50s the patch passed with JDK v1.8.0 +1 javadoc 0m 48s the patch passed with JDK v1.7.0_79 +1 unit 0m 53s hbase-client in the patch passed with JDK v1.8.0. +1 unit 82m 22s hbase-server in the patch passed with JDK v1.8.0. +1 unit 0m 56s hbase-client in the patch passed with JDK v1.7.0_79. +1 unit 80m 41s hbase-server in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 216m 32s Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782205/14865-master-v7.patch JIRA Issue HBASE-14865 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / c8b9754 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/110/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/110/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/110/testReport/ modules C: hbase-client hbase-server U: . Max memory used 191MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HBASE-Build/110/console This message was automatically generated.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          With Java 1.7.0_60 , TestSecureIPC fails running against hadoop 2.7.0 :

          testRpcCallWithEnabledKerberosSaslAuth(org.apache.hadoop.hbase.security.TestSecureIPC)  Time elapsed: 0.049 sec  <<< ERROR!
          java.io.IOException: Login failure for hbase/localhost@EXAMPLE.COM from keytab /Users/tyu/trunk/hbase-server/target/test-data/76d0c754-8dca-4c88-9933-b5a77646a750/keytab: javax.security.auth.login.LoginException: Null realm name (601)
          	at org.apache.hadoop.security.UserGroupInformation.loginUserFromKeytab(UserGroupInformation.java:962)
          	at org.apache.hadoop.hbase.security.AbstractTestSecureIPC.loginKerberosPrincipal(AbstractTestSecureIPC.java:180)
          	at org.apache.hadoop.hbase.security.AbstractTestSecureIPC.setUpTest(AbstractTestSecureIPC.java:112)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:606)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
          	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239)
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - With Java 1.7.0_60 , TestSecureIPC fails running against hadoop 2.7.0 : testRpcCallWithEnabledKerberosSaslAuth(org.apache.hadoop.hbase.security.TestSecureIPC) Time elapsed: 0.049 sec <<< ERROR! java.io.IOException: Login failure for hbase/localhost@EXAMPLE.COM from keytab /Users/tyu/trunk/hbase-server/target/test-data/76d0c754-8dca-4c88-9933-b5a77646a750/keytab: javax.security.auth.login.LoginException: Null realm name (601) at org.apache.hadoop.security.UserGroupInformation.loginUserFromKeytab(UserGroupInformation.java:962) at org.apache.hadoop.hbase.security.AbstractTestSecureIPC.loginKerberosPrincipal(AbstractTestSecureIPC.java:180) at org.apache.hadoop.hbase.security.AbstractTestSecureIPC.setUpTest(AbstractTestSecureIPC.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239)
          Hide
          appy Appy added a comment -

          What Ted Yu is seeing is very likely another java dependent thing. I would like to de-couple looking for its cause from this jira if the tests in QA pass. Will that be okay?

          Show
          appy Appy added a comment - What Ted Yu is seeing is very likely another java dependent thing. I would like to de-couple looking for its cause from this jira if the tests in QA pass. Will that be okay?
          Hide
          appy Appy added a comment -

          So debugging the errors seen by matteo, here are the details:
          The tests pass java version 1.7.0_75 but fails for java 1.7.0_80 and Java 8.
          It's because these 3 lines of compatibility code were removed somewhere in between those versions. As a result of which UGI in hadoop-common makes wrong conclusion here that there is no keytab and fails to authenticate. The bug in UGI was fixed by HADOOP-11287 but only exists in 2.7.0+. So using java 1.7.0_80+ with hadoop-common <= 2.6.x, you'll definitely see this error.
          QA didn't fail because master uses hadoop-common 2.7.0+.
          The issue was always there but didn't surface earlier since all tests were only testing code paths for correct execution, but none for failures, until this patch added some.
          If there is a hadoop release of 2.5.x or 2.6.x, we can ask them to backport the fix. There's really nothing else we can do here (except a release note to notify users).
          Andrew Purtell, can you ptal at my assessment.

          Show
          appy Appy added a comment - So debugging the errors seen by matteo, here are the details: The tests pass java version 1.7.0_75 but fails for java 1.7.0_80 and Java 8. It's because these 3 lines of compatibility code were removed somewhere in between those versions. As a result of which UGI in hadoop-common makes wrong conclusion here that there is no keytab and fails to authenticate. The bug in UGI was fixed by HADOOP-11287 but only exists in 2.7.0+. So using java 1.7.0_80+ with hadoop-common <= 2.6.x, you'll definitely see this error. QA didn't fail because master uses hadoop-common 2.7.0+. The issue was always there but didn't surface earlier since all tests were only testing code paths for correct execution, but none for failures, until this patch added some. If there is a hadoop release of 2.5.x or 2.6.x, we can ask them to backport the fix. There's really nothing else we can do here (except a release note to notify users). Andrew Purtell , can you ptal at my assessment.
          Hide
          mbertozzi Matteo Bertozzi added a comment -

          for me the patch on master passes, but the one on branch-1 fail with both jdk 1.7.0_80-b15 and 1.8.0_66-b17

            TestSecureIPC.testSaslNoCommonQop 
          Expected: (an instance of javax.security.sasl.SaslException and exception with message a string containing "No common protection layer between client and server")
               but: an instance of javax.security.sasl.SaslException <GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)> is a org.ietf.jgss.GSSException
          Stacktrace was: GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)
          	at sun.security.jgss.krb5.Krb5InitCredential.getInstance(Krb5InitCredential.java:147)
          	at sun.security.jgss.krb5.Krb5MechFactory.getCredentialElement(Krb5MechFactory.java:121)
          	at sun.security.jgss.krb5.Krb5MechFactory.getMechanismContext(Krb5MechFactory.java:187)
          	at sun.security.jgss.GSSManagerImpl.getMechanismContext(GSSManagerImpl.java:223)
          	at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:212)
          	at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:179)
          	at com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:193)
          	at org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:181)
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:617)
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$700(RpcClientImpl.java:162)
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:743)
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:740)
          	at java.security.AccessController.doPrivileged(Native Method)
          	at javax.security.auth.Subject.doAs(Subject.java:415)
          	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1614)
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:740)
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:902)
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:871)
          	at org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1232)
          	at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:221)
          	at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:326)
          	at org.apache.hadoop.hbase.ipc.protobuf.generated.TestDelayedRpcProtos$TestDelayedService$BlockingStub.test(TestDelayedRpcProtos.java:1115)
          	at org.apache.hadoop.hbase.ipc.TestDelayedRpc$TestThread.run(TestDelayedRpc.java:277)
          
          Show
          mbertozzi Matteo Bertozzi added a comment - for me the patch on master passes, but the one on branch-1 fail with both jdk 1.7.0_80-b15 and 1.8.0_66-b17 TestSecureIPC.testSaslNoCommonQop Expected: (an instance of javax.security.sasl.SaslException and exception with message a string containing "No common protection layer between client and server") but: an instance of javax.security.sasl.SaslException <GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)> is a org.ietf.jgss.GSSException Stacktrace was: GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt) at sun.security.jgss.krb5.Krb5InitCredential.getInstance(Krb5InitCredential.java:147) at sun.security.jgss.krb5.Krb5MechFactory.getCredentialElement(Krb5MechFactory.java:121) at sun.security.jgss.krb5.Krb5MechFactory.getMechanismContext(Krb5MechFactory.java:187) at sun.security.jgss.GSSManagerImpl.getMechanismContext(GSSManagerImpl.java:223) at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:212) at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:179) at com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:193) at org.apache.hadoop.hbase.security.HBaseSaslRpcClient.saslConnect(HBaseSaslRpcClient.java:181) at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupSaslConnection(RpcClientImpl.java:617) at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.access$700(RpcClientImpl.java:162) at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:743) at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection$2.run(RpcClientImpl.java:740) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:415) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1614) at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:740) at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.writeRequest(RpcClientImpl.java:902) at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.tracedWriteRequest(RpcClientImpl.java:871) at org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1232) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:221) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:326) at org.apache.hadoop.hbase.ipc.protobuf.generated.TestDelayedRpcProtos$TestDelayedService$BlockingStub.test(TestDelayedRpcProtos.java:1115) at org.apache.hadoop.hbase.ipc.TestDelayedRpc$TestThread.run(TestDelayedRpc.java:277)
          Hide
          appy Appy added a comment -

          Tried running with Java 1.7. Did this on a Mac

          export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_75.jdk/Contents/Home
          mvn clean test -Dtest=TestSecureIPC
          

          Test passed successfully. Which java does our presubmit use?
          Ted Yu

          Show
          appy Appy added a comment - Tried running with Java 1.7. Did this on a Mac export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_75.jdk/Contents/Home mvn clean test -Dtest=TestSecureIPC Test passed successfully. Which java does our presubmit use? Ted Yu
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Running tests locally using Java 1.7.0_60, I got several failures which were caused by the following:

          testAsyncRpc(org.apache.hadoop.hbase.security.TestSecureRPC)  Time elapsed: 0.051 sec  <<< ERROR!
          java.io.IOException: Login failure for hbase/localhost@EXAMPLE.COM from keytab /Users/tyu/trunk/hbase-server/target/test-data/a6b76e6d-77c3-43a0-81b3-39b514f7eb76/keytab: javax.security.auth.login.LoginException: Null realm name (601)
          	at sun.security.krb5.Realm.parseRealm(Realm.java:174)
          	at sun.security.krb5.Realm.<init>(Realm.java:59)
          	at sun.security.krb5.PrincipalName.<init>(PrincipalName.java:375)
          	at sun.security.krb5.KrbAsReq.<init>(KrbAsReq.java:118)
          	at sun.security.krb5.KrbAsReqBuilder.build(KrbAsReqBuilder.java:268)
          	at sun.security.krb5.KrbAsReqBuilder.send(KrbAsReqBuilder.java:318)
          	at sun.security.krb5.KrbAsReqBuilder.action(KrbAsReqBuilder.java:364)
          	at com.sun.security.auth.module.Krb5LoginModule.attemptAuthentication(Krb5LoginModule.java:735)
          	at com.sun.security.auth.module.Krb5LoginModule.login(Krb5LoginModule.java:584)
          

          Appy:
          Can you see if the above is reproducible on your computer ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Running tests locally using Java 1.7.0_60, I got several failures which were caused by the following: testAsyncRpc(org.apache.hadoop.hbase.security.TestSecureRPC) Time elapsed: 0.051 sec <<< ERROR! java.io.IOException: Login failure for hbase/localhost@EXAMPLE.COM from keytab /Users/tyu/trunk/hbase-server/target/test-data/a6b76e6d-77c3-43a0-81b3-39b514f7eb76/keytab: javax.security.auth.login.LoginException: Null realm name (601) at sun.security.krb5.Realm.parseRealm(Realm.java:174) at sun.security.krb5.Realm.<init>(Realm.java:59) at sun.security.krb5.PrincipalName.<init>(PrincipalName.java:375) at sun.security.krb5.KrbAsReq.<init>(KrbAsReq.java:118) at sun.security.krb5.KrbAsReqBuilder.build(KrbAsReqBuilder.java:268) at sun.security.krb5.KrbAsReqBuilder.send(KrbAsReqBuilder.java:318) at sun.security.krb5.KrbAsReqBuilder.action(KrbAsReqBuilder.java:364) at com.sun.security.auth.module.Krb5LoginModule.attemptAuthentication(Krb5LoginModule.java:735) at com.sun.security.auth.module.Krb5LoginModule.login(Krb5LoginModule.java:584) Appy: Can you see if the above is reproducible on your computer ?
          Hide
          apurtell Andrew Purtell added a comment -

          +1
          looks fine to commit to me

          Show
          apurtell Andrew Purtell added a comment - +1 looks fine to commit to me
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12775424/HBASE-14865-branch-1.patch
          against branch-1 branch at commit da0cc598feab995eed12527d90805dd627674035.
          ATTACHMENT ID: 12775424

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not generate new checkstyle errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16734//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16734//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16734//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16734//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12775424/HBASE-14865-branch-1.patch against branch-1 branch at commit da0cc598feab995eed12527d90805dd627674035. ATTACHMENT ID: 12775424 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not generate new checkstyle errors. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16734//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16734//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16734//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16734//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12775249/HBASE-14865-master-v7.patch
          against master branch at commit aa41232a877d7a8485bc361fd62150d7c094e9a4.
          ATTACHMENT ID: 12775249

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not generate new checkstyle errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16729//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16729//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16729//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16729//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12775249/HBASE-14865-master-v7.patch against master branch at commit aa41232a877d7a8485bc361fd62150d7c094e9a4. ATTACHMENT ID: 12775249 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not generate new checkstyle errors. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16729//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16729//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16729//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16729//console This message is automatically generated.
          Hide
          appy Appy added a comment -

          Since trying re-submitting to trigger test-patch didn't work 2 times, resubmitting v6 as v7 (rebased).

          Show
          appy Appy added a comment - Since trying re-submitting to trigger test-patch didn't work 2 times, resubmitting v6 as v7 (rebased).
          Hide
          appy Appy added a comment -

          Weird that its -1 overall despite individual +1s. Triggering another run.

          Show
          appy Appy added a comment - Weird that its -1 overall despite individual +1s. Triggering another run.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12775114/HBASE-14865-branch-1.2.patch
          against branch-1.2 branch at commit 92e178df28120fcae2aad47f3e4b1cc6e06a8404.
          ATTACHMENT ID: 12775114

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not generate new checkstyle errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16723//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16723//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16723//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16723//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12775114/HBASE-14865-branch-1.2.patch against branch-1.2 branch at commit 92e178df28120fcae2aad47f3e4b1cc6e06a8404. ATTACHMENT ID: 12775114 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not generate new checkstyle errors. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16723//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16723//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16723//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16723//console This message is automatically generated.
          Hide
          mbertozzi Matteo Bertozzi added a comment -

          +1

          Show
          mbertozzi Matteo Bertozzi added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12774921/HBASE-14865-master-v6.patch
          against master branch at commit 756e6de2a0948c39a4fb3ab880dd9d182d645dbc.
          ATTACHMENT ID: 12774921

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 checkstyle. The applied patch does not generate new checkstyle errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12774921/HBASE-14865-master-v6.patch against master branch at commit 756e6de2a0948c39a4fb3ab880dd9d182d645dbc. ATTACHMENT ID: 12774921 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 checkstyle . The applied patch does not generate new checkstyle errors. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16705//console This message is automatically generated.
          Hide
          appy Appy added a comment -

          Javadoc warnings are unrelated and are being fixed in HBASE-14896.

          Show
          appy Appy added a comment - Javadoc warnings are unrelated and are being fixed in HBASE-14896 .
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12774889/HBASE-14865-master-v5.patch
          against master branch at commit 999ae691559a49321138eb7718eb204435639db9.
          ATTACHMENT ID: 12774889

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 checkstyle. The applied patch does not generate new checkstyle errors.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12774889/HBASE-14865-master-v5.patch against master branch at commit 999ae691559a49321138eb7718eb204435639db9. ATTACHMENT ID: 12774889 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 checkstyle . The applied patch does not generate new checkstyle errors. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16703//console This message is automatically generated.
          Hide
          appy Appy added a comment -

          v6: just removes the pom dependency i had to add to be able to debug in Intellij. It's strange that mvn test -Dtest=TestAsyncSecureIPC was working (terminal) , but Intellij was reporting missing dependency when I tried to debug the test case.

          Show
          appy Appy added a comment - v6: just removes the pom dependency i had to add to be able to debug in Intellij. It's strange that mvn test -Dtest=TestAsyncSecureIPC was working (terminal) , but Intellij was reporting missing dependency when I tried to debug the test case.
          Hide
          appy Appy added a comment -

          fix checkstyles

          Show
          appy Appy added a comment - fix checkstyles
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12774403/HBASE-14865-master-v4.patch
          against master branch at commit 90bdb0dc7412f3ae8fc1e14ce033bf115c6332f3.
          ATTACHMENT ID: 12774403

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 18686 checkstyle errors (more than the master's current 18685 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16665//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16665//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16665//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16665//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12774403/HBASE-14865-master-v4.patch against master branch at commit 90bdb0dc7412f3ae8fc1e14ce033bf115c6332f3. ATTACHMENT ID: 12774403 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 18686 checkstyle errors (more than the master's current 18685 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16665//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16665//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16665//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16665//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12774135/HBASE-14865-master-v3.patch
          against master branch at commit 4cc341b9c23183fe12225fb03d30ac975a87d07c.
          ATTACHMENT ID: 12774135

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 18687 checkstyle errors (more than the master's current 18686 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16657//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16657//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16657//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16657//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12774135/HBASE-14865-master-v3.patch against master branch at commit 4cc341b9c23183fe12225fb03d30ac975a87d07c. ATTACHMENT ID: 12774135 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 18687 checkstyle errors (more than the master's current 18686 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16657//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16657//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16657//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16657//console This message is automatically generated.
          Hide
          appy Appy added a comment -

          fixing checkstyle errors.

          Show
          appy Appy added a comment - fixing checkstyle errors.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12773950/HBASE-14865-master-v2.patch
          against master branch at commit 6b11adbfa4aa565eff1bb141170c8e183aed3e4b.
          ATTACHMENT ID: 12773950

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 18690 checkstyle errors (more than the master's current 18686 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16643//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16643//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16643//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16643//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12773950/HBASE-14865-master-v2.patch against master branch at commit 6b11adbfa4aa565eff1bb141170c8e183aed3e4b. ATTACHMENT ID: 12773950 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 18690 checkstyle errors (more than the master's current 18686 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16643//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16643//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16643//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16643//console This message is automatically generated.
          Hide
          appy Appy added a comment -

          Fixes AsyncSecureIPC test.
          Test was timing out because async had this bug to retry infinite times if kerberos is enabled and test was configured to timeout in 5 seconds. So even though the expected exception was happening, it'll keep retrying and timeout. :-/

          Show
          appy Appy added a comment - Fixes AsyncSecureIPC test. Test was timing out because async had this bug to retry infinite times if kerberos is enabled and test was configured to timeout in 5 seconds. So even though the expected exception was happening, it'll keep retrying and timeout. :-/
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12773783/HBASE-14865-master.patch
          against master branch at commit 55087ce8887b5be38b0fda0dda3fbf2f92c13778.
          ATTACHMENT ID: 12773783

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 27 new or modified tests.

          +1 hadoop versions. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 protoc. The applied patch does not increase the total number of protoc compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 18689 checkstyle errors (more than the master's current 18686 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn post-site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.security.TestAsyncSecureIPC

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16638//testReport/
          Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16638//artifact/patchprocess/newFindbugsWarnings.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16638//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16638//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12773783/HBASE-14865-master.patch against master branch at commit 55087ce8887b5be38b0fda0dda3fbf2f92c13778. ATTACHMENT ID: 12773783 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 27 new or modified tests. +1 hadoop versions . The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 protoc . The applied patch does not increase the total number of protoc compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 18689 checkstyle errors (more than the master's current 18686 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn post-site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.TestAsyncSecureIPC Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16638//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16638//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16638//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16638//console This message is automatically generated.

            People

            • Assignee:
              appy Appy
              Reporter:
              appy Appy
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development