[HBASE-14663] HStore::close does not honor config hbase.rs.evictblocksonclose

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16, 2.0.0
• Component/s: BlockCache, regionserver
• Hadoop Flags: Reviewed
• Assignee: Vladimir Rodionov
• Reporter: Randy Fox
• Created: 21/Oct/15 18:28
• Updated: 10/Jun/20 04:44
• Resolved: 22/Oct/15 05:00

Description

I noticed moving regions was slow and due to the wait for the bucket cache to clear. I tried setting hbase.rs.evictblocksonclose and it did not help.

I see the HStore::close method has evictonclose hard coded to true instead of letting the config dictate:

// close each store file in parallel
CompletionService<Void> completionService =
new ExecutorCompletionService<Void>(storeFileCloserThreadPool);
for (final StoreFile f : result) {
completionService.submit(new Callable<Void>() {
@Override
public Void call() throws IOException

{ f.closeReader(true); return null; }

});
}

Issue Links

• relates to: HBASE-24529 hbase.rs.evictblocksonclose is not honored when removing compacted files and closing the storefiles