[HBASE-14281] ArrayIndexOutOfBoundsException in CellComparator#getMinimumMidpointArray, part 2

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 1.0.0, 1.0.1, 1.0.2
• Component/s: regionserver
• Assignee: Unassigned
• Reporter: Michael Rose
• Created: 21/Aug/15 15:16
• Updated: 01/Jul/22 21:02
• Resolved: 25/Aug/15 03:02

Description

Follow-on issue for HBASE-13329: CellComparator#getMinimumMidpointArray seems to have had a necessary change omitted and the patch only covered one of the two places diffIdx could overflow the short.

For some background, we ran into the HBASE-13329 issue where a flush would cause a regionserver abort. After abort, the region in question would almost indefinitely sit in the FAILED_OPEN state. Applying the patch from HBASE-13329 didn't solve the issue, but I noticed a comment in that issue which applied the same change in CellComparator#getMinimumMidpointArray, but the change was omitted from the attached patch.

RS abort for reference:

slave3.xxx.xxx.xxx,60020,1440131603772: Replay of WAL required. Forcing server shutdown
org.apache.hadoop.hbase.DroppedSnapshotException: region: deduplication,P\xDFt\x10\x053e73ceff5a2717d2ba76887ea21a2a8e353d1372\xFE,1438362391124.2bb6a602be6b1bfcea0508af4ba42235.
at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2243)
at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1972)
at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1935)
at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:1833)
at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:452)
at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:413)
at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$800(MemStoreFlusher.java:70)
at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:229)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NegativeArraySizeException
at org.apache.hadoop.hbase.CellComparator.getMinimumMidpointArray(CellComparator.java:494)
at org.apache.hadoop.hbase.CellComparator.getMidpoint(CellComparator.java:448)
at org.apache.hadoop.hbase.io.hfile.HFileWriterV2.finishBlock(HFileWriterV2.java:165)
at org.apache.hadoop.hbase.io.hfile.HFileWriterV2.checkBlockBoundary(HFileWriterV2.java:146)
at org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:263)
at org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:949)

Issue Links

• is related to: HBASE-13329 ArrayIndexOutOfBoundsException in CellComparator#getMinimumMidpointArray