[HBASE-14234] Procedure-V2: Exception encountered in WALProcedureStore#rollWriter() should be properly handled

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.0, 1.1.2, 1.3.0, 2.0.0
• Component/s: proc-v2
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 18/Aug/15 01:29
• Updated: 01/Jul/22 20:56
• Resolved: 19/Aug/15 16:34

Description

Observed the following in recent Jenkins build (https://builds.apache.org/job/HBase-TRUNK/6732/console):

testWALfencingWithoutWALRolling(org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures)  Time elapsed: 9.938 sec  <<< ERROR!
org.apache.hadoop.ipc.RemoteException: failed to create file /user/jenkins/test-data/0d9e3047-6bb1-4219-9ed2-5b9884176321/MasterProcWALs/state-00000000000000000002.log for DFSClient_NONMAPREDUCE_-966558185_1 for client 127.0.0.1 because current leaseholder is trying to recreate file.
	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.recoverLeaseInternal(FSNamesystem.java:2589)
	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInternal(FSNamesystem.java:2386)

When file creation fails (e.g. due to RemoteException), we should handle the exception by returning false.
Similar handling can be applied to failure in writing header.

Thanks to mbertozzi for offline discussion.