[HBASE-14222] Improve DrainBarrier

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Abandoned
• Component/s: util
• Assignee: Unassigned
• Reporter: Hiroshi Ikeda
• Created: 14/Aug/15 06:19
• Updated: 01/Jul/22 20:53
• Resolved: 01/Jul/22 20:53

Description

1. DrainBarrier.stopAndDrainOps may wait forever if DrainBarrier.endOp changes its state and calls Object.notifyAll just before stopAndDrainOps enters the synchronized block to call Object.wait. Moreover, Object.wait may wake up false-positively, and stopAndDrainOps may break the block before outstanding operations are complete.

2. Some tests for DrainBarrier catch and ignore AssertionError explicitly thrown JUnit's fail method.

The implementation of DrainBarrier is a little complex, and I'll fix and refactor it.