[HBASE-1405] Threads.shutdown has unnecessary branch

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.20.0
• Assignee: Nitay Joffe
• Reporter: Nitay Joffe
• Created: 11/May/09 19:37
• Updated: 13/Sep/09 22:24
• Resolved: 11/May/09 19:49

Description

        if (joinwait == -1) {
          t.join();
        } else {
          t.join(joinwait);
        }

We don't need to use -1 as a special value, as join already has a special value of 0:

From Thread.join() javadoc:
"Waits at most millis milliseconds for this thread to die. A timeout of 0 means to wait forever."