[HBASE-13993] WALProcedureStore fencing is not effective if new WAL rolls

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0, 1.1.2, 2.0.0
• Component/s: master
• Assignee: Enis Soztutar
• Reporter: Enis Soztutar
• Created: 30/Jun/15 00:23
• Updated: 17/Jun/22 18:15
• Resolved: 10/Jul/15 20:50

Description

WAL fencing for the WALProcedureStore is a bit different than the fencing done for region server WALs.

In case of this sequence of events, the WAL is not fenced (especially with HBASE-13832 patch):

• master1 creates WAL with logId = 1: /MasterProcWALs/state-00000000000000000001.log
• master2 takes over, fences logId = 1 with recoverLease(), creates logId=2: /MasterProcWALs/state-00000000000000000002.log.
• master2 writes some procedures and rolls the logId2, and creates logId = 3, and deletes logId = 2.
• master1 now tries to write a procedure, gets lease mismatch, rolls the log from 1 to 2, and succeeds the write since it can write logId = 2 (master2 uses logId=3 now).