[HBASE-13989] Threshold for combined MemStore and BlockCache percentages is not checked

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.2, 1.2.0, 1.1.2, 1.3.0, 2.0.0
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 29/Jun/15 16:56
• Updated: 18/Dec/15 06:44
• Resolved: 30/Jun/15 00:26

Description

In HeapMemoryManager#doInit():

    globalMemStorePercentMinRange = conf.getFloat(MEMSTORE_SIZE_MIN_RANGE_KEY,
        globalMemStorePercent);
    globalMemStorePercentMaxRange = conf.getFloat(MEMSTORE_SIZE_MAX_RANGE_KEY,
        globalMemStorePercent);
...
    if (globalMemStorePercent == globalMemStorePercentMinRange
        && globalMemStorePercent == globalMemStorePercentMaxRange) {
      return false;
    }

If memory tuning is not specified, globalMemStorePercentMinRange and globalMemStorePercentMaxRange would carry the value of globalMemStorePercent.
This would make doInit() exit before checking the threshold for combined MemStore and BlockCache percentages.