Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13989

Threshold for combined MemStore and BlockCache percentages is not checked

    XMLWordPrintableJSON

    Details

    • Hadoop Flags:
      Reviewed

      Description

      In HeapMemoryManager#doInit():

          globalMemStorePercentMinRange = conf.getFloat(MEMSTORE_SIZE_MIN_RANGE_KEY,
              globalMemStorePercent);
          globalMemStorePercentMaxRange = conf.getFloat(MEMSTORE_SIZE_MAX_RANGE_KEY,
              globalMemStorePercent);
      ...
          if (globalMemStorePercent == globalMemStorePercentMinRange
              && globalMemStorePercent == globalMemStorePercentMaxRange) {
            return false;
          }
      

      If memory tuning is not specified, globalMemStorePercentMinRange and globalMemStorePercentMaxRange would carry the value of globalMemStorePercent.
      This would make doInit() exit before checking the threshold for combined MemStore and BlockCache percentages.

        Attachments

        1. 13989-v2.txt
          4 kB
          Ted Yu
        2. 13989-v1.txt
          2 kB
          Ted Yu

          Activity

            People

            • Assignee:
              yuzhihong@gmail.com Ted Yu
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: