Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13906

Improve handling of NeedUnmanagedConnectionException

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.0.0, 1.1.0
    • 1.2.0, 1.3.0
    • API, Client
    • None
    • With this patch NeedUnmanagedConnectionException is effectively treated as non-retryable exception, but for backwards compatibility purposes we don't throw it directly, but instead wrap into DoNotRetryIOException when we return error to the caller.

    Description

      During my investigation of HBASE-13833, I made this comment

      One other thing: should we somehow handle NeedUnmanagedConnectionException similarly to DoNotRetryIOException? It's too late to wire them up thusly, but for the case of bulk load when the bug is expressed, we go through the full 35x retry loop before eventually failing the RPC. This would be applicable to branch-1.

      This would apply only to branch-1 as master no longer has unmanaged connections. Probably we cannot change the inheritance hierarchy due to compatibility guarantees, but maybe we can do something like everywhere we look for DNRIOE, we do the same for NUCE.

      Attachments

        1. HBASE-13906-branch-1.v1.patch
          13 kB
          Mikhail Antonov
        2. HBASE-13906-branch-1.v1.patch
          13 kB
          Nick Dimiduk
        3. HBASE-13906-branch-1.v1.patch
          13 kB
          Mikhail Antonov

        Issue Links

          Activity

            People

              mantonov Mikhail Antonov
              ndimiduk Nick Dimiduk
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: