[HBASE-13454] SecureClient#setupIOStreams should handle all Exceptions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.94.27
• Fix Version/s: 0.94.28
• Component/s: Client, security
• Hadoop Flags: Reviewed
• Assignee: Jianwei Cui
• Reporter: Jianwei Cui
• Created: 11/Apr/15 08:38
• Updated: 24/Jun/22 18:35
• Resolved: 16/Jun/15 20:04

Description

Similar to HBASE-9256 , SecureClient#setupIOStreams should also catch up all Exception. In our production environment, an OutOfMemoryError is thrown in SecureClient#setupIOStreams, leaving an unclosed SecureConnection with its inputStream/outputStream still null. Therefore, following calls will be attached to this connection and will encounter NPE in HBaseClient#sendParam:

java.lang.NullPointerException
at org.apache.hadoop.hbase.ipc.HBaseClient$Connection.sendParam(HBaseClient.java:619)
at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:977)
at org.apache.hadoop.hbase.ipc.SecureRpcEngine$Invoker.invoke(SecureRpcEngine.java:107)
at $Proxy21.replicateLogEntries(Unknown Source)
at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.shipEdits(ReplicationSource.java:772)
at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:451)

We'd fix this in 0.94.