[HBASE-13318] RpcServer.getListenerAddress should handle when the accept channel is closed

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16, 2.0.0
• Labels: thread-safety
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Lars Hofhansl
• Created: 24/Mar/15 01:14
• Updated: 27/Jan/16 15:28
• Resolved: 26/Oct/15 22:11

Description

We just saw exceptions like these:

Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" java.lang.NullPointerException
	at org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
	at org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
	at org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
	at java.lang.Thread.run(Thread.java:745)

Looks like RpcServer$Listener.getAddress should be synchronized (acceptChannel is set to null upon exiting the thread under in a synchronized block).

Should be happening very rarely only.