Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-12791

HBase does not attempt to clean up an aborted split when the regionserver shutting down

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 1.0.0, 2.0.0, 0.98.10, 1.1.0
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBase not cleaning the daughter region directories from HDFS if region server shut down after creating the daughter region directories during the split.

      Here the logs.

      -> RS shutdown after creating the daughter regions.

      2014-12-31 09:05:41,406 DEBUG [regionserver60020-splits-1419996941385] zookeeper.ZKAssign: regionserver:60020-0x14a9701e53100d1, quorum=localhost:2181, baseZNode=/hbase Transitioned node 80c665138d4fa32da4d792d8ed13206f from RS_ZK_REQUEST_REGION_SPLIT to RS_ZK_REQUEST_REGION_SPLIT
      2014-12-31 09:05:41,514 DEBUG [regionserver60020-splits-1419996941385] regionserver.HRegion: Closing t,,1419996880699.80c665138d4fa32da4d792d8ed13206f.: disabling compactions & flushes
      2014-12-31 09:05:41,514 DEBUG [regionserver60020-splits-1419996941385] regionserver.HRegion: Updates disabled for region t,,1419996880699.80c665138d4fa32da4d792d8ed13206f.
      2014-12-31 09:05:41,516 INFO  [StoreCloserThread-t,,1419996880699.80c665138d4fa32da4d792d8ed13206f.-1] regionserver.HStore: Closed f
      2014-12-31 09:05:41,518 INFO  [regionserver60020-splits-1419996941385] regionserver.HRegion: Closed t,,1419996880699.80c665138d4fa32da4d792d8ed13206f.
      2014-12-31 09:05:49,922 DEBUG [regionserver60020-splits-1419996941385] regionserver.MetricsRegionSourceImpl: Creating new MetricsRegionSourceImpl for table t dd9731ee43b104da565257ca1539aa8c
      2014-12-31 09:05:49,922 DEBUG [regionserver60020-splits-1419996941385] regionserver.HRegion: Instantiated t,,1419996941401.dd9731ee43b104da565257ca1539aa8c.
      2014-12-31 09:05:49,929 DEBUG [regionserver60020-splits-1419996941385] regionserver.MetricsRegionSourceImpl: Creating new MetricsRegionSourceImpl for table t 2e40a44511c0e187d357d651f13a1dab
      2014-12-31 09:05:49,929 DEBUG [regionserver60020-splits-1419996941385] regionserver.HRegion: Instantiated t,row2,1419996941401.2e40a44511c0e187d357d651f13a1dab.
      Wed Dec 31 09:06:30 IST 2014 Terminating regionserver
      2014-12-31 09:06:30,465 INFO  [Thread-8] regionserver.ShutdownHook: Shutdown hook starting; hbase.shutdown.hook=true; fsShutdownHook=org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@42d2282e
      

      -> Skipping rollback if RS stopped or stopping so we end up in dirty daughter regions in HDFS.

      2014-12-31 09:07:49,547 INFO  [regionserver60020-splits-1419996941385] regionserver.SplitRequest: Skip rollback/cleanup of failed split of t,,1419996880699.80c665138d4fa32da4d792d8ed13206f. because server is stopped
      java.io.InterruptedIOException: Interrupted after 0 tries  on 350
              at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:156)
      

      Because of this hbck always showing inconsistencies.

      ERROR: Region { meta => null, hdfs => hdfs://localhost:9000/hbase/data/default/t/2e40a44511c0e187d357d651f13a1dab, deployed =>  } on HDFS, but not listed in hbase:meta or deployed on any region server
      ERROR: Region { meta => null, hdfs => hdfs://localhost:9000/hbase/data/default/t/dd9731ee43b104da565257ca1539aa8c, deployed =>  } on HDFS, but not listed in hbase:meta or deployed on any region server
      

      If we try to repair then we end up in overlap regions in hbase:meta. and both daughter regions and parent are online.

      1. HBASE-12791_98_v2.patch
        12 kB
        Rajeshbabu Chintaguntla
      2. HBASE-12791_98_v3.patch
        13 kB
        rajeshbabu
      3. HBASE-12791_98.patch
        12 kB
        Rajeshbabu Chintaguntla
      4. HBASE-12791_addendum.patch
        0.8 kB
        Rajeshbabu Chintaguntla
      5. HBASE-12791_branch1_v2.patch
        13 kB
        Rajeshbabu Chintaguntla
      6. HBASE-12791_branch1_v3.patch
        14 kB
        rajeshbabu
      7. HBASE-12791_branch1.patch
        11 kB
        Rajeshbabu Chintaguntla
      8. HBASE-12791_v2.patch
        13 kB
        Rajeshbabu Chintaguntla
      9. HBASE-12791_v3.patch
        12 kB
        Rajeshbabu Chintaguntla
      10. HBASE-12791_v4.patch
        13 kB
        Rajeshbabu Chintaguntla
      11. HBASE-12791_v4.patch
        13 kB
        Rajeshbabu Chintaguntla
      12. HBASE-12791_v5.patch
        13 kB
        Rajeshbabu Chintaguntla
      13. HBASE-12791_v6.patch
        14 kB
        Rajeshbabu Chintaguntla
      14. HBASE-12791_v6.patch
        14 kB
        Rajeshbabu Chintaguntla
      15. HBASE-12791.patch
        13 kB
        Rajeshbabu Chintaguntla

        Issue Links

          Activity

          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          To solve this we need not skip the rollback even if the regionserver stopping so that the the dirty daughter regions will be deleted(if rs is stopping we need not open parent region in rollback). Some times if regionserver terminated abnormally then we may not call rollback so we need to delete the directories in SSH if any regions in SPLITTING_NEW state.
          And also while fixing meta holes in hbck we should check for overlaps beforehand and need not add them to meta in such case. Now in this scenario both daugher regions start and end keys are in the range of existing parent region in meta so we need not add them to meta and also we can consider the directories what ever left are because of aborted splits and we can delete them.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - To solve this we need not skip the rollback even if the regionserver stopping so that the the dirty daughter regions will be deleted(if rs is stopping we need not open parent region in rollback). Some times if regionserver terminated abnormally then we may not call rollback so we need to delete the directories in SSH if any regions in SPLITTING_NEW state. And also while fixing meta holes in hbck we should check for overlaps beforehand and need not add them to meta in such case. Now in this scenario both daugher regions start and end keys are in the range of existing parent region in meta so we need not add them to meta and also we can consider the directories what ever left are because of aborted splits and we can delete them.
          Hide
          enis Enis Soztutar added a comment -

          In offline discussion with Rajesh, it seems that not cleaning up after SplitTransaction abort might be ok, since in case of RS hard fail (kill -9, etc), the SplitTransaction will still leave dirty state around (mainly hdfs directories for daughters). I think we should make master clean up the daughter dirs in case a SPLIT fails.

          And also while fixing meta holes in hbck we should check for overlaps beforehand and need not add them to meta in such case.

          +1.

          Show
          enis Enis Soztutar added a comment - In offline discussion with Rajesh, it seems that not cleaning up after SplitTransaction abort might be ok, since in case of RS hard fail (kill -9, etc), the SplitTransaction will still leave dirty state around (mainly hdfs directories for daughters). I think we should make master clean up the daughter dirs in case a SPLIT fails. And also while fixing meta holes in hbck we should check for overlaps beforehand and need not add them to meta in such case. +1.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Here is the patch cleaning daughter regions of aborted split and SSH and also cleaning the region directories in hbck while fixing meta holes.
          Please review.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Here is the patch cleaning daughter regions of aborted split and SSH and also cleaning the region directories in hbck while fixing meta holes. Please review.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          lgtm

          +              HRegionFileSystem.deleteRegionFromFileSystem(conf, fs, tableDir, hri);
          +            }
          

          Please add a log in the above case.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - lgtm + HRegionFileSystem.deleteRegionFromFileSystem(conf, fs, tableDir, hri); + } Please add a log in the above case.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12689978/HBASE-12791.patch
          against master branch at commit ac95cc1fbb951bb9db96f2738f621d1d7cd45739.
          ATTACHMENT ID: 12689978

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2086 checkstyle errors (more than the master's current 2081 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + List<HRegionInfo> tableRegions = MetaTableAccessor.getTableRegions(conn, hri.getTable(), true);
          + hri.getEndKey()) >= 0) && Bytes.compareTo(region.getStartKey(), hri.getEndKey()) <= 0) {
          + Path parentRegionDir = StoreFileInfo.getReferredToFile(referenceFilePath).getParent().getParent();
          + HRegionFileSystem.deleteRegionFromFileSystem(getConf(), fs, regionDir.getParent(), hri);
          + assertErrors(doFsck(conf, false, true, false, false, false, false, false, false, false, false, null) , new ERROR_CODE[] {

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStartedServerIsAlive(TestHttpServerLifecycle.java:71)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12689978/HBASE-12791.patch against master branch at commit ac95cc1fbb951bb9db96f2738f621d1d7cd45739. ATTACHMENT ID: 12689978 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2086 checkstyle errors (more than the master's current 2081 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + List<HRegionInfo> tableRegions = MetaTableAccessor.getTableRegions(conn, hri.getTable(), true); + hri.getEndKey()) >= 0) && Bytes.compareTo(region.getStartKey(), hri.getEndKey()) <= 0) { + Path parentRegionDir = StoreFileInfo.getReferredToFile(referenceFilePath).getParent().getParent(); + HRegionFileSystem.deleteRegionFromFileSystem(getConf(), fs, regionDir.getParent(), hri); + assertErrors(doFsck(conf, false, true, false, false, false, false, false, false, false, false, null) , new ERROR_CODE[] { +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStartedServerIsAlive(TestHttpServerLifecycle.java:71) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12298//console This message is automatically generated.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Fixed line lengths and added the comment as Ted suggested.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Fixed line lengths and added the comment as Ted suggested.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690115/HBASE-12791_v2.patch
          against master branch at commit 2ba6053163ed62dc3f72bdc5d8380690a235e28b.
          ATTACHMENT ID: 12690115

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2082 checkstyle errors (more than the master's current 2081 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690115/HBASE-12791_v2.patch against master branch at commit 2ba6053163ed62dc3f72bdc5d8380690a235e28b. ATTACHMENT ID: 12690115 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2082 checkstyle errors (more than the master's current 2081 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12305//console This message is automatically generated.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          +1

          Show
          yuzhihong@gmail.com Ted Yu added a comment - +1
          Hide
          enis Enis Soztutar added a comment -

          Thanks Rajesh for working on this. A couple of comments for the patch:

          • It is the right approach for the master to clean up after SplitTransaction in case it fails to do so. I think this is good design.
          • Can we move the cleaning logic away from RegionStates though (ideally to SSH, or to a utility method).
          • Can you add logging here:
            +          } catch (IOException e) {
            +            // Nothing to do here. 
            +          }
            
          • The hbck change seems costly. We already have all the regions from hdfs and meta at that point no?
          Show
          enis Enis Soztutar added a comment - Thanks Rajesh for working on this. A couple of comments for the patch: It is the right approach for the master to clean up after SplitTransaction in case it fails to do so. I think this is good design. Can we move the cleaning logic away from RegionStates though (ideally to SSH, or to a utility method). Can you add logging here: + } catch (IOException e) { + // Nothing to do here. + } The hbck change seems costly. We already have all the regions from hdfs and meta at that point no?
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Enis Soztutar
          Thanks for the review. Here is the updated patch.

          Can we move the cleaning logic away from RegionStates though (ideally to SSH, or to a utility method).

          We cannot do the cleanup in SSH because in RegionStates#serverOffline we are removing the transitions of regions need not open. So we don't get the regions in SPLITTING_NEW in SSH. So I have added utility method in FSUtils to cleanup.

          Can you add logging here:

          Added the log here.

          The hbck change seems costly. We already have all the regions from hdfs and meta at that point no?

          In the current patch making use of regions info already loaded from meta and hdfs.

          Apart from this I have tried to handle cleanup during master startup but not able to identify the regions in SPLITTING_NEW state because we are not persisting the daughter regions until unless split commit happen(which is correct only).
          In branch-1 and 0.98 not able to identify regions in SPLITTING_NEW state during master startup because we are delegating dead server handling to SSH which mostly depend on meta and in memory state(not reading from zk).

          Please review.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Enis Soztutar Thanks for the review. Here is the updated patch. Can we move the cleaning logic away from RegionStates though (ideally to SSH, or to a utility method). We cannot do the cleanup in SSH because in RegionStates#serverOffline we are removing the transitions of regions need not open. So we don't get the regions in SPLITTING_NEW in SSH. So I have added utility method in FSUtils to cleanup. Can you add logging here: Added the log here. The hbck change seems costly. We already have all the regions from hdfs and meta at that point no? In the current patch making use of regions info already loaded from meta and hdfs. Apart from this I have tried to handle cleanup during master startup but not able to identify the regions in SPLITTING_NEW state because we are not persisting the daughter regions until unless split commit happen(which is correct only). In branch-1 and 0.98 not able to identify regions in SPLITTING_NEW state during master startup because we are delegating dead server handling to SSH which mostly depend on meta and in memory state(not reading from zk). Please review.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Here are the patches for branch-1 and 0.98 branches.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Here are the patches for branch-1 and 0.98 branches.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690626/HBASE-12791_98.patch
          against master branch at commit 7dce0d5c4549a1d5986d3bc82734924219d8bb25.
          ATTACHMENT ID: 12690626

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12345//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690626/HBASE-12791_98.patch against master branch at commit 7dce0d5c4549a1d5986d3bc82734924219d8bb25. ATTACHMENT ID: 12690626 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12345//console This message is automatically generated.
          Hide
          enis Enis Soztutar added a comment -

          The changes in RegionStates for cleanup seems good.
          For the HBCK change,

          • We are doing some action without a parameter check (-fixAssignments, -fixMeta, etc). Hbck running without any parameters should never do any destructive action. Can we do this by adding a parameter, smt like -fixFailedSplitAttempts.
          • Can we save the results after we sort the regions for the table so that we do not repeat the work for multiple regions in this state. In case there is a large number of regions (100K) this will save some cycles.
            Other than those it looks good.
          Show
          enis Enis Soztutar added a comment - The changes in RegionStates for cleanup seems good. For the HBCK change, We are doing some action without a parameter check (-fixAssignments, -fixMeta, etc). Hbck running without any parameters should never do any destructive action. Can we do this by adding a parameter, smt like -fixFailedSplitAttempts . Can we save the results after we sort the regions for the table so that we do not repeat the work for multiple regions in this state. In case there is a large number of regions (100K) this will save some cycles. Other than those it looks good.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          We are doing some action without a parameter check (-fixAssignments, -fixMeta, etc). Hbck running without any parameters should never do any destructive action. Can we do this by adding a parameter, smt like -fixFailedSplitAttempts.

          It's in shouldFixMeta case Enis Soztutar. So it won't be a problem.

          Can we save the results after we sort the regions for the table

          In the current patch storing the regions derived from meta in TableInfo.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - We are doing some action without a parameter check (-fixAssignments, -fixMeta, etc). Hbck running without any parameters should never do any destructive action. Can we do this by adding a parameter, smt like -fixFailedSplitAttempts. It's in shouldFixMeta case Enis Soztutar . So it won't be a problem. Can we save the results after we sort the regions for the table In the current patch storing the regions derived from meta in TableInfo.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690707/HBASE-12791_v4.patch
          against master branch at commit 645fbd7d87450b31b67b1e535cdb9c1cf50ffd16.
          ATTACHMENT ID: 12690707

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2085 checkstyle errors (more than the master's current 2084 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690707/HBASE-12791_v4.patch against master branch at commit 645fbd7d87450b31b67b1e535cdb9c1cf50ffd16. ATTACHMENT ID: 12690707 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2085 checkstyle errors (more than the master's current 2084 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12355//console This message is automatically generated.
          Hide
          enis Enis Soztutar added a comment -

          Thanks Rajesh for the updated patch. It looks good to ship. Can you please re-trigger hadoopqa again. Andrew Purtell FYI.

          Show
          enis Enis Soztutar added a comment - Thanks Rajesh for the updated patch. It looks good to ship. Can you please re-trigger hadoopqa again. Andrew Purtell FYI.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Resubmitting the same patch to trigger HadoopQA again.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Resubmitting the same patch to trigger HadoopQA again.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690964/HBASE-12791_v4.patch
          against master branch at commit dde713ee4e7845a1bd272b1c318ba0af08577e4d.
          ATTACHMENT ID: 12690964

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2077 checkstyle errors (more than the master's current 2076 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.util.TestHBaseFsck

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.TestNodeHealthCheckChore.testHealthCheckerTimeout(TestNodeHealthCheckChore.java:75)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690964/HBASE-12791_v4.patch against master branch at commit dde713ee4e7845a1bd272b1c318ba0af08577e4d. ATTACHMENT ID: 12690964 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2077 checkstyle errors (more than the master's current 2076 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.util.TestHBaseFsck -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.TestNodeHealthCheckChore.testHealthCheckerTimeout(TestNodeHealthCheckChore.java:75) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12372//console This message is automatically generated.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Patch fixing the failed test case.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Patch fixing the failed test case.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690995/HBASE-12791_v5.patch
          against master branch at commit 4d7c65ae849355849f24a1d0a6f7c87ad18d3bb7.
          ATTACHMENT ID: 12690995

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2077 checkstyle errors (more than the master's current 2076 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690995/HBASE-12791_v5.patch against master branch at commit 4d7c65ae849355849f24a1d0a6f7c87ad18d3bb7. ATTACHMENT ID: 12690995 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2077 checkstyle errors (more than the master's current 2076 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12376//console This message is automatically generated.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Here are the patches for 0.98 and branch-1

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Here are the patches for 0.98 and branch-1
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12691103/HBASE-12791_branch1_v2.patch
          against master branch at commit 4bfd35aabc83b007871fe9a8537cd5ac9cd84500.
          ATTACHMENT ID: 12691103

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12387//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691103/HBASE-12791_branch1_v2.patch against master branch at commit 4bfd35aabc83b007871fe9a8537cd5ac9cd84500. ATTACHMENT ID: 12691103 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12387//console This message is automatically generated.
          Hide
          enis Enis Soztutar added a comment -

          +1.

          Show
          enis Enis Soztutar added a comment - +1.
          Hide
          apurtell Andrew Purtell added a comment -

          +1

          Show
          apurtell Andrew Purtell added a comment - +1
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          While testing in the cluster observed some region in SPLITTING_NEW state left in transition. Handled in this patch.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - While testing in the cluster observed some region in SPLITTING_NEW state left in transition. Handled in this patch.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          While testing in the cluster observed regions in SPLITTING_NEW state after when RS restart before PONR. Handled in this patch.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - While testing in the cluster observed regions in SPLITTING_NEW state after when RS restart before PONR. Handled in this patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12691546/HBASE-12791_v6.patch
          against master branch at commit f6a017ce6302853ef8421dc6adf1a099059f4e30.
          ATTACHMENT ID: 12691546

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691546/HBASE-12791_v6.patch against master branch at commit f6a017ce6302853ef8421dc6adf1a099059f4e30. ATTACHMENT ID: 12691546 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12401//console This message is automatically generated.
          Hide
          rajesh23 rajeshbabu added a comment -

          Here are the updated patches I am going to commit now.

          Show
          rajesh23 rajeshbabu added a comment - Here are the updated patches I am going to commit now.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12691550/HBASE-12791_branch1_v3.patch
          against master branch at commit f6a017ce6302853ef8421dc6adf1a099059f4e30.
          ATTACHMENT ID: 12691550

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12402//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691550/HBASE-12791_branch1_v3.patch against master branch at commit f6a017ce6302853ef8421dc6adf1a099059f4e30. ATTACHMENT ID: 12691550 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12402//console This message is automatically generated.
          Hide
          apurtell Andrew Purtell added a comment -
          Show
          apurtell Andrew Purtell added a comment - Ok. Thanks Rajeshbabu Chintaguntla
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #6011 (See https://builds.apache.org/job/HBase-TRUNK/6011/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev 5b850caa801d033d800bf6c1bea32aa2c7bda273)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #6011 (See https://builds.apache.org/job/HBase-TRUNK/6011/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev 5b850caa801d033d800bf6c1bea32aa2c7bda273) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Pushed to 0.98+ branches. Thanks for review Enis Soztutar,Andrew Purtell.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Pushed to 0.98+ branches. Thanks for review Enis Soztutar , Andrew Purtell .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #651 (See https://builds.apache.org/job/HBase-1.0/651/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev cce9e586c0be7edbf37e637628996eedeaff7700)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #651 (See https://builds.apache.org/job/HBase-1.0/651/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev cce9e586c0be7edbf37e637628996eedeaff7700) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.1 #74 (See https://builds.apache.org/job/HBase-1.1/74/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev f4e0cbc26c9139e7ec1a77e3cebc7d3fb36fcee6)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1 #74 (See https://builds.apache.org/job/HBase-1.1/74/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev f4e0cbc26c9139e7ec1a77e3cebc7d3fb36fcee6) hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #787 (See https://builds.apache.org/job/HBase-0.98/787/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev 01039eb2f5d143ec40e1f6b8dae9d35ff67e55c4)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98 #787 (See https://builds.apache.org/job/HBase-0.98/787/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev 01039eb2f5d143ec40e1f6b8dae9d35ff67e55c4) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #752 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/752/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev 01039eb2f5d143ec40e1f6b8dae9d35ff67e55c4)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #752 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/752/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down(Rajeshbabu) (rajeshbabu: rev 01039eb2f5d143ec40e1f6b8dae9d35ff67e55c4) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Small change to avoid possible NPE when region replica enabled and replica with 0 id is not present in hbase:meta.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Small change to avoid possible NPE when region replica enabled and replica with 0 id is not present in hbase:meta.
          Hide
          enis Enis Soztutar added a comment -

          +1.

          Show
          enis Enis Soztutar added a comment - +1.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Pushed the addendum to all branches. Thanks Enis Soztutar for review.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Pushed the addendum to all branches. Thanks Enis Soztutar for review.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.1 #100 (See https://builds.apache.org/job/HBase-1.1/100/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev d21ea4e57071115deb597e31163a28264d47f89f)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1 #100 (See https://builds.apache.org/job/HBase-1.1/100/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev d21ea4e57071115deb597e31163a28264d47f89f) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #677 (See https://builds.apache.org/job/HBase-1.0/677/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev 8f7506722c21954592c3e928383a930ab9ab36bf)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #677 (See https://builds.apache.org/job/HBase-1.0/677/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev 8f7506722c21954592c3e928383a930ab9ab36bf) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6048 (See https://builds.apache.org/job/HBase-TRUNK/6048/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev e13b9938a16327d029afc3aaea8f42d531ddb306)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6048 (See https://builds.apache.org/job/HBase-TRUNK/6048/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev e13b9938a16327d029afc3aaea8f42d531ddb306) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #813 (See https://builds.apache.org/job/HBase-0.98/813/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev b846575b8ec057c3c21ad38a2ef547b718c9f881)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #813 (See https://builds.apache.org/job/HBase-0.98/813/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev b846575b8ec057c3c21ad38a2ef547b718c9f881) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #774 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/774/)
          HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev b846575b8ec057c3c21ad38a2ef547b718c9f881)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #774 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/774/ ) HBASE-12791 HBase does not attempt to clean up an aborted split when the regionserver shutting down-addendum(Rajeshbabu) (rajeshbabu: rev b846575b8ec057c3c21ad38a2ef547b718c9f881) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 1.0.0 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 1.0.0 release.

            People

            • Assignee:
              rajeshbabu Rajeshbabu Chintaguntla
              Reporter:
              rajeshbabu Rajeshbabu Chintaguntla
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development