[HBASE-12392] Incorrect implementation of CompactionRequest.isRetainDeleteMarkers

• Type: Sub-task
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: hbase-11339
• Fix Version/s: hbase-11339, 2.0.0
• Component/s: regionserver, Scanners
• Hadoop Flags: Reviewed
• Assignee: Jingcheng Du
• Reporter: Jingcheng Du
• Created: 31/Oct/14 07:03
• Updated: 17/Jun/22 05:56
• Resolved: 31/Oct/14 10:15

Description

Now in the implementation of the isRetainDeleteMarkers method, the code look like,

return (this.retainDeleteMarkers != null) ? this.retainDeleteMarkers.booleanValue()
        : isAllFiles();

It means for a major compaction in a normal store, this method returns true. Consequently the delete marks could not be deleted in the major compaction, which leads the unit test TestKeepDeletes fails.
The correct implementation should be,

return (this.retainDeleteMarkers != null) ? this.retainDeleteMarkers.booleanValue()
        : !isAllFiles();