Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11339 HBase MOB
  3. HBASE-12392

Incorrect implementation of CompactionRequest.isRetainDeleteMarkers

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: hbase-11339
    • Fix Version/s: hbase-11339, 2.0.0
    • Component/s: regionserver, Scanners
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Now in the implementation of the isRetainDeleteMarkers method, the code look like,

      return (this.retainDeleteMarkers != null) ? this.retainDeleteMarkers.booleanValue()
              : isAllFiles();
      

      It means for a major compaction in a normal store, this method returns true. Consequently the delete marks could not be deleted in the major compaction, which leads the unit test TestKeepDeletes fails.
      The correct implementation should be,

      return (this.retainDeleteMarkers != null) ? this.retainDeleteMarkers.booleanValue()
              : !isAllFiles();
      

        Attachments

        1. HBASE-12392.diff
          0.7 kB
          Jingcheng Du

          Activity

            People

            • Assignee:
              jingcheng.du@intel.com Jingcheng Du
              Reporter:
              jingcheng.du@intel.com Jingcheng Du
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: