[HBASE-12327] MetricsHBaseServerSourceFactory#createContextName has wrong conditions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.99.2
• Assignee: Unassigned
• Reporter: Sanghyun Yun
• Created: 23/Oct/14 07:43
• Updated: 04/Apr/18 23:05
• Resolved: 22/Nov/14 08:29

Description

MetricsHBaseServerSourceFactory#createContextName has wrong conditions.

It checks serverName contains "HMaster" or "HRegion".

MetricsHBaseServerSourceFactory.java

...
  protected static String createContextName(String serverName) {
    if (serverName.contains("HMaster")) {
      return "Master";
    } else if (serverName.contains("HRegion")) {
      return "RegionServer";
    }
    return "IPC";
  }
...

But, passed serverName actually contains "master" or "regionserver" by HMaster#getProcessName and HRegionServer#getProcessName.

HMaster.java

...
  // MASTER is name of the webapp and the attribute name used stuffing this
  //instance into web context.
  public static final String MASTER = "master";
...
  protected String getProcessName() {
    return MASTER;
  }
...

HRegionServer.java

...
  /** region server process name */
  public static final String REGIONSERVER = "regionserver";
...
  protected String getProcessName() {
    return REGIONSERVER;
  }
...

Issue Links

• is part of: HBASE-12328 Need to separate JvmMetrics for Master and RegionServer