[HBASE-12237] HBaseZeroCopyByteString#wrap() should not be called in hbase-client code

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 0.98.8, 0.99.2
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 12/Oct/14 17:22
• Updated: 06/Apr/18 17:54
• Resolved: 13/Oct/14 17:30

Description

In RegionServerCoprocessorRpcChannel#callExecService(), there is following code:

    final ClientProtos.CoprocessorServiceCall call =
        ClientProtos.CoprocessorServiceCall.newBuilder()
            .setRow(HBaseZeroCopyByteString.wrap(HConstants.EMPTY_BYTE_ARRAY))

Calling HBaseZeroCopyByteString#wrap() in hbase-client module causes regression w.r.t. HBASE-11118

Consequence of this is that users of cascading app, such as Lingual, would not be able to access HBase.

Issue Links

• relates to: HBASE-11912 Catch some bad practices at compile time with error-prone