[HBASE-12235] Backport to 0.94: HBASE-9002 TestDistributedLogSplitting.testRecoverdEdits should test correct region

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.94.0
• Fix Version/s: 0.94.25
• Component/s: test

Environment

0.94.15 compiled with jdk6 running on jdk7 (but I don't think it's relevant)

• Hadoop Flags: Reviewed
• Assignee: Sean Busbey
• Reporter: Sean Busbey
• Created: 11/Oct/14 07:46
• Updated: 29/Nov/14 22:31
• Resolved: 13/Oct/14 01:29

Description

I had TestDistributedLogSplitting.testRecoveredEdits fail on a internal test rig. It's very infrequent.

The proximal failure looks like HBASE-9002, the assertion finds 0 edits instead of 1000.

Looking through the logs, the #regions printed is 1

line 236        LOG.info("#regions = " + regions.size());

And then in the makeHLog method I never see any log entry for the actual writing

line 569    for (int i = 0; i < n; i++) {
line 570      LOG.info("region " + hris.get(i).getRegionNameAsString() + " has " + counts[i] + " edits");
line 571    }

I think what's happening is we're picking a region that is META or ROOT, so the checks after the "#regions=" line removes the region and we end up inserting no data.

It looks like the patch for HBASE-9002 should fix this.