[HBASE-12117] Constructors that use Configuration may be harmful

• Type: Umbrella
• Status: Closed
• Priority: Major
• Resolution: Resolved
• Assignee: Unassigned
• Reporter: Andrew Kyle Purtell
• Created: 30/Sep/14 02:25
• Updated: 17/Jun/22 17:31
• Resolved: 17/Jun/22 17:31

Description

There's a common pattern in HBase code where in the constructor, or in an initialization method also called once per instantiation, or both, we look up values from Hadoop Configuration and store them into fields. This can be expensive if the object is frequently created. Configuration is a heavyweight registry that does a lot of string operations and regex matching. See attached example. Method calls into Configuration account for 48.25% of CPU time when creating the HTable object in 0.98. (The remainder is spent instantiating the RPC controller via reflection, a separate issue that merits followup elsewhere.) Creation of HTable instances is expected to be a lightweight operation if a client is using unmanaged HConnections; however creating HTable instances takes up about 18% of the client's total on-CPU time. This is just one example where constructors that use Configuration may be harmful.

Sub-Tasks

• Cache configuration and RpcController selection for Table in Connection: Closed
• Backport HBASE-12128 (Cache configuration and RpcController selection for Table in Connection) to 0.98: Closed