Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11871 Avoid usage of KeyValueUtil#ensureKeyValue
  3. HBASE-12112

Avoid KeyValueUtil#ensureKeyValue some more simple cases

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.99.1
    • regionserver
    • None
    • Reviewed

    Description

      This include fixes with

      • Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
      • Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages
      • HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance
      • Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter

      Attachments

        1. HBASE-12112_V2.patch
          42 kB
          Anoop Sam John
        2. HBASE-12112_V2.patch
          34 kB
          Anoop Sam John
        3. HBASE-12112_V4.patch
          41 kB
          Anoop Sam John
        4. HBASE-12112_V4.patch
          41 kB
          Anoop Sam John
        5. HBASE-12112.patch
          31 kB
          Anoop Sam John

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            anoop.hbase Anoop Sam John
            anoop.hbase Anoop Sam John
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment