[HBASE-12030] Wrong compaction report and assert when MOB compaction switches to minor

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: hbase-11339
• Fix Version/s: hbase-11339, 2.0.0
• Component/s: Compaction, regionserver
• Hadoop Flags: Reviewed
• Assignee: Anoop Sam John
• Reporter: Matteo Bertozzi
• Created: 19/Sep/14 18:22
• Updated: 17/Jun/22 17:17
• Resolved: 25/Sep/14 04:19

Description

when zookeeper is down during a major compaction or a sweep tool run in progress, we switch to a minor.

try {
  zk = MobZookeeper.newInstance(this.conf, compactionName);
} catch (KeeperException e) {
  LOG.error("Cannot connect to the zookeeper, ready to perform the minor compaction instead", e);
  // change the major compaction into a minor one
  compaction.getRequest().setIsMajor(false);
  return super.compact(compaction);
}

but the "request start" (HRegion.reportCompactionRequestStart) is "major" and increments the major-compactions counter
while the "request end" (HRegion.reportCompactionRequestEnd) is "minor" and decrements the minor-compactions counter
triggering the assert newValue >= 0, since we are decrementing the wrong counter