HBase
  1. HBase
  2. HBASE-11858

Audit regionserver classes that are missing InterfaceAudience

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, 2.0.0, 0.98.7
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are ~20 classes in regionserver that are missing InterfaceAudience markers.

      Most are probably private, but HBASE-10378 has already hit atleast one that should be LimitedPrivate(COPROC), so it's worth checking and cleaning things up.

      1. HBASE-11858.patch
        29 kB
        Sean Busbey
      2. HBASE-11858-0.98.patch
        27 kB
        Andrew Purtell

        Issue Links

          Activity

          Hide
          Sean Busbey added a comment -

          In addition to the fact that it's our stated position, here are the current counts on master that inform my assertion that the missing entries are probably private.

          busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.Private" hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l
               132
          busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.Public" hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l
                 3
          busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.LimitedPrivate" hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l
                 6
          busbey2-MBA:hbase busbey$ comm -23 all_regionserver_class.txt audience_labeled_class.txt | wc -l
                21
          
          Show
          Sean Busbey added a comment - In addition to the fact that it's our stated position , here are the current counts on master that inform my assertion that the missing entries are probably private. busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.Private" hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l 132 busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.Public" hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l 3 busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.LimitedPrivate" hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l 6 busbey2-MBA:hbase busbey$ comm -23 all_regionserver_class.txt audience_labeled_class.txt | wc -l 21
          Hide
          Sean Busbey added a comment -

          list of classes missing annotations

          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//AnnotationReadingPriorityFunction.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//BaseRowProcessor.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//DefaultStoreFlusher.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//DisabledRegionSplitPolicy.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//IncreasingToUpperBoundRegionSplitPolicy.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//MetricsRegionWrapperImpl.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//MultiRowMutationProcessor.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//RegionCoprocessorHost.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//RegionServerCoprocessorHost.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//RowTooBigException.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//RpcSchedulerFactory.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//StoreUtils.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//StorefileRefresherChore.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//StripeMultiFileWriter.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//StripeStoreFlusher.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//compactions/StripeCompactor.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/HLogFactory.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/HLogUtil.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/KeyValueCompression.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/SecureProtobufLogReader.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/SecureProtobufLogWriter.java
          hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/SecureWALCellCodec.java
          
          Show
          Sean Busbey added a comment - list of classes missing annotations hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//AnnotationReadingPriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//BaseRowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//DefaultStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//DisabledRegionSplitPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//IncreasingToUpperBoundRegionSplitPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//MetricsRegionWrapperImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//MultiRowMutationProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//RegionCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//RegionServerCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//RowTooBigException.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//RpcSchedulerFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//StoreUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//StorefileRefresherChore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//StripeMultiFileWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//StripeStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//compactions/StripeCompactor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/HLogFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/HLogUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/KeyValueCompression.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/SecureProtobufLogReader.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/SecureProtobufLogWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver//wal/SecureWALCellCodec.java
          Hide
          Andrew Purtell added a comment -

          but HBASE-10378 has already hit atleast one that should be LimitedPrivate(COPROC), so it's worth checking and cleaning things up.

          And see HBASE-11857

          Show
          Andrew Purtell added a comment - but HBASE-10378 has already hit atleast one that should be LimitedPrivate(COPROC), so it's worth checking and cleaning things up. And see HBASE-11857
          Hide
          Sean Busbey added a comment -

          attaching result of review, plus a missed import statement in BaseRowProcessor

          Show
          Sean Busbey added a comment - attaching result of review, plus a missed import statement in BaseRowProcessor
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12666411/HBASE-11858.patch
          against trunk revision .
          ATTACHMENT ID: 12666411

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.replication.TestPerTableCFReplication
          org.apache.hadoop.hbase.TestRegionRebalancing

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12666411/HBASE-11858.patch against trunk revision . ATTACHMENT ID: 12666411 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestPerTableCFReplication org.apache.hadoop.hbase.TestRegionRebalancing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10709//console This message is automatically generated.
          Hide
          Anoop Sam John added a comment -

          +1 after going through the RB patch

          Show
          Anoop Sam John added a comment - +1 after going through the RB patch
          Hide
          Enis Soztutar added a comment -

          Did you guys see HBASE-10462. Maybe we should adopt the test there for hbase-server as well.

          Show
          Enis Soztutar added a comment - Did you guys see HBASE-10462 . Maybe we should adopt the test there for hbase-server as well.
          Hide
          Enis Soztutar added a comment -

          Let me do a quick review. I think we'll like to have this in branch-1 and possibly 0.98 as well.

          Show
          Enis Soztutar added a comment - Let me do a quick review. I think we'll like to have this in branch-1 and possibly 0.98 as well.
          Hide
          Andrew Purtell added a comment -

          Sure, +1 for 0.98

          Show
          Andrew Purtell added a comment - Sure, +1 for 0.98
          Hide
          Andrew Purtell added a comment -

          Will commit to 0.98+ shortly.

          Show
          Andrew Purtell added a comment - Will commit to 0.98+ shortly.
          Hide
          Andrew Purtell added a comment -

          Attaching what I committed to 0.98

          Show
          Andrew Purtell added a comment - Attaching what I committed to 0.98
          Hide
          Andrew Purtell added a comment -

          Pushed to 0.98+

          Show
          Andrew Purtell added a comment - Pushed to 0.98+
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #155 (See https://builds.apache.org/job/HBase-1.0/155/)
          HBASE-11858 Add InterfaceAudience for classes missing it in regionserver packages. (apurtell: rev e3ee2491b7e478a35042686665438d33cca11fef)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RpcSchedulerFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StorefileRefresherChore.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowTooBigException.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DisabledRegionSplitPolicy.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-1.0 #155 (See https://builds.apache.org/job/HBase-1.0/155/ ) HBASE-11858 Add InterfaceAudience for classes missing it in regionserver packages. (apurtell: rev e3ee2491b7e478a35042686665438d33cca11fef) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RpcSchedulerFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StorefileRefresherChore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowTooBigException.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DisabledRegionSplitPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5470 (See https://builds.apache.org/job/HBase-TRUNK/5470/)
          HBASE-11858 Add InterfaceAudience for classes missing it in regionserver packages. (apurtell: rev 8b5582370ecc9bb8f10e19ae4fd7cf60bb6c2108)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RpcSchedulerFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowTooBigException.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DisabledRegionSplitPolicy.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StorefileRefresherChore.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5470 (See https://builds.apache.org/job/HBase-TRUNK/5470/ ) HBASE-11858 Add InterfaceAudience for classes missing it in regionserver packages. (apurtell: rev 8b5582370ecc9bb8f10e19ae4fd7cf60bb6c2108) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RpcSchedulerFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowTooBigException.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DisabledRegionSplitPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StorefileRefresherChore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #499 (See https://builds.apache.org/job/HBase-0.98/499/)
          HBASE-11858 Add InterfaceAudience for classes missing it in regionserver packages. (apurtell: rev 9d9201ca44610550076f046da12a3bf4cdcf9ac6)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RpcSchedulerFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DisabledRegionSplitPolicy.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98 #499 (See https://builds.apache.org/job/HBase-0.98/499/ ) HBASE-11858 Add InterfaceAudience for classes missing it in regionserver packages. (apurtell: rev 9d9201ca44610550076f046da12a3bf4cdcf9ac6) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RpcSchedulerFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DisabledRegionSplitPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #473 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/473/)
          HBASE-11858 Add InterfaceAudience for classes missing it in regionserver packages. (apurtell: rev 9d9201ca44610550076f046da12a3bf4cdcf9ac6)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DisabledRegionSplitPolicy.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RpcSchedulerFactory.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #473 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/473/ ) HBASE-11858 Add InterfaceAudience for classes missing it in regionserver packages. (apurtell: rev 9d9201ca44610550076f046da12a3bf4cdcf9ac6) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DisabledRegionSplitPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RpcSchedulerFactory.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              Sean Busbey
              Reporter:
              Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development