Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: documentation
    • Labels:
      None
    1. HBASE-11779.patch
      5 kB
      Misty Stanley-Jones
    2. HBASE-11534.patch
      5 kB
      Misty Stanley-Jones

      Activity

      Hide
      Misty Stanley-Jones added a comment -

      Can you have a look, Esteban Gutierrez? I think I put it all the places that are important.

      Show
      Misty Stanley-Jones added a comment - Can you have a look, Esteban Gutierrez ? I think I put it all the places that are important.
      Hide
      Misty Stanley-Jones added a comment -

      To reviewers: The patch is really confusing, because the previous example for hbase-env.sh was actually a diff output. I changed the example to just show the file. I have not changed the actual hbase-env.sh even though it might look like i did.

      Show
      Misty Stanley-Jones added a comment - To reviewers: The patch is really confusing, because the previous example for hbase-env.sh was actually a diff output. I changed the example to just show the file. I have not changed the actual hbase-env.sh even though it might look like i did.
      Hide
      Esteban Gutierrez added a comment -

      +1 if we could have a common value for JAVA_HOME as /usr/java/latest instead.

      Show
      Esteban Gutierrez added a comment - +1 if we could have a common value for JAVA_HOME as /usr/java/latest instead.
      Hide
      Misty Stanley-Jones added a comment -

      Sorry I don't know how the first patch got the wrong name ...

      Show
      Misty Stanley-Jones added a comment - Sorry I don't know how the first patch got the wrong name ...
      Hide
      Srikanth Srungarapu added a comment -

      +1 (non-binding)

      Show
      Srikanth Srungarapu added a comment - +1 (non-binding)
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12662923/HBASE-11779.patch
      against trunk revision .
      ATTACHMENT ID: 12662923

      +1 @author. The patch does not contain any @author tags.

      +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 javadoc. The javadoc tool appears to have generated 6 warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.replication.TestPerTableCFReplication
      org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait
      org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
      org.apache.hadoop.hbase.client.TestReplicaWithCluster
      org.apache.hadoop.hbase.client.TestMultiParallel

      -1 core zombie tests. There are 2 zombie test(s): at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:292)
      at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:266)
      at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportWithTargetName(TestExportSnapshot.java:224)

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12662923/HBASE-11779.patch against trunk revision . ATTACHMENT ID: 12662923 +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 6 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestPerTableCFReplication org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster org.apache.hadoop.hbase.client.TestReplicaWithCluster org.apache.hadoop.hbase.client.TestMultiParallel -1 core zombie tests . There are 2 zombie test(s): at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:292) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:266) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportWithTargetName(TestExportSnapshot.java:224) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10498//console This message is automatically generated.
      Hide
      Misty Stanley-Jones added a comment -

      Nick Dimiduk want to have a look before you refresh the site? It would be good to get this in.

      Show
      Misty Stanley-Jones added a comment - Nick Dimiduk want to have a look before you refresh the site? It would be good to get this in.
      Hide
      Nick Dimiduk added a comment -

      Huh. I didn't know this JAVA_HOME thing was a requirement

      +1, I'll get this committed.

      As for refreshing site, I can't actually build the site. Upgrading my java version is on the list, but I don't think i'll get it done today.

      Show
      Nick Dimiduk added a comment - Huh. I didn't know this JAVA_HOME thing was a requirement +1, I'll get this committed. As for refreshing site, I can't actually build the site. Upgrading my java version is on the list, but I don't think i'll get it done today.
      Hide
      Nick Dimiduk added a comment -

      Rather, mvn site works, but javadoc:aggregate does not.

      Show
      Nick Dimiduk added a comment - Rather, mvn site works, but javadoc:aggregate does not.
      Hide
      Nick Dimiduk added a comment -

      Committed to master. Thanks for another fix Misty Stanley-Jones!

      Show
      Nick Dimiduk added a comment - Committed to master. Thanks for another fix Misty Stanley-Jones !
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK #5421 (See https://builds.apache.org/job/HBase-TRUNK/5421/)
      HBASE-11779 Document the new requirement to set JAVA_HOME before starting HBase (Misty Stanley-Jones) (ndimiduk: rev a2fc3efebfb277d2e57712a4c5b210a01fd7d5c8)

      • src/main/docbkx/getting_started.xml
      • src/main/docbkx/configuration.xml
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5421 (See https://builds.apache.org/job/HBase-TRUNK/5421/ ) HBASE-11779 Document the new requirement to set JAVA_HOME before starting HBase (Misty Stanley-Jones) (ndimiduk: rev a2fc3efebfb277d2e57712a4c5b210a01fd7d5c8) src/main/docbkx/getting_started.xml src/main/docbkx/configuration.xml

        People

        • Assignee:
          Misty Stanley-Jones
          Reporter:
          Misty Stanley-Jones
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development