HBase
  1. HBase
  2. HBASE-11717

Remove unused config 'hbase.offheapcache.percentage' from hbase-default.xml and book

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0, 2.0.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      hbase.offheapcache.percentage is unused now.

      <property>
          <name>hbase.offheapcache.percentage</name>
          <value>0</value>
          <description>The percentage of the off heap space (-XX:MaxDirectMemorySize) to be
           allocated towards the experimental off heap "SlabCache" (This is different to
           the BucketCache -- see the package javadoc for org.apache.hadoop.hbase.io.hfile
           for more on your options). If you desire the cache to be disabled, simply set this
            value to 0.</description>
        </property>
      
      1. HBASE-11717.patch
        4 kB
        Anoop Sam John
      2. HBASE-11717_V3-0.99.patch
        5 kB
        Anoop Sam John
      3. HBASE-11717_V3.patch
        10 kB
        Anoop Sam John
      4. HBASE-11717_V2.patch
        8 kB
        Anoop Sam John

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-1.0 #103 (See https://builds.apache.org/job/HBase-1.0/103/)
        HBASE-11717 Remove unused config 'hbase.offheapcache.percentage' from hbase-default.xml and book. (Anoop) (anoopsamjohn: rev 2eb0757301b98384140e2e1028deb5d29c531936)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java
        • hbase-common/src/main/resources/hbase-default.xml
        • hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableSnapshotInputFormat.java
        • src/main/docbkx/upgrading.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-1.0 #103 (See https://builds.apache.org/job/HBase-1.0/103/ ) HBASE-11717 Remove unused config 'hbase.offheapcache.percentage' from hbase-default.xml and book. (Anoop) (anoopsamjohn: rev 2eb0757301b98384140e2e1028deb5d29c531936) hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java hbase-common/src/main/resources/hbase-default.xml hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableSnapshotInputFormat.java src/main/docbkx/upgrading.xml
        Hide
        Hudson added a comment -

        ABORTED: Integrated in HBase-TRUNK #5399 (See https://builds.apache.org/job/HBase-TRUNK/5399/)
        HBASE-11717 Remove unused config 'hbase.offheapcache.percentage' from hbase-default.xml and book. (Anoop) (anoopsamjohn: rev cabcb6ca232f1ed784190207c1c526f6e9f6e280)

        • src/main/docbkx/book.xml
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableSnapshotInputFormat.java
        • hbase-common/src/main/resources/hbase-default.xml
        • src/main/docbkx/upgrading.xml
        Show
        Hudson added a comment - ABORTED: Integrated in HBase-TRUNK #5399 (See https://builds.apache.org/job/HBase-TRUNK/5399/ ) HBASE-11717 Remove unused config 'hbase.offheapcache.percentage' from hbase-default.xml and book. (Anoop) (anoopsamjohn: rev cabcb6ca232f1ed784190207c1c526f6e9f6e280) src/main/docbkx/book.xml hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableSnapshotInputFormat.java hbase-common/src/main/resources/hbase-default.xml src/main/docbkx/upgrading.xml
        Hide
        Anoop Sam John added a comment -

        What I committed to branch-1.
        book.xml we will copy from trunk at release time.

        Show
        Anoop Sam John added a comment - What I committed to branch-1. book.xml we will copy from trunk at release time.
        Hide
        Anoop Sam John added a comment -

        Pushed to master and branch-1. Thanks all for reviews.

        Show
        Anoop Sam John added a comment - Pushed to master and branch-1. Thanks all for reviews.
        Hide
        Enis Soztutar added a comment -

        1 for branch-1.

        Show
        Enis Soztutar added a comment - 1 for branch-1 .
        Hide
        Anoop Sam John added a comment -

        Will commit tomorrow unless objections. Ping Enis Soztutar for branch-1

        Show
        Anoop Sam John added a comment - Will commit tomorrow unless objections. Ping Enis Soztutar for branch-1
        Hide
        Anoop Sam John added a comment -

        Removing the references from book, which Sean noticed. Thanks for the review.

        Show
        Anoop Sam John added a comment - Removing the references from book, which Sean noticed. Thanks for the review.
        Hide
        Sean Busbey added a comment -

        If we're removing the SlabCache from the book, there are a couple of additional references:

        book.xml:

             <section
                xml:id="block.cache">
                <title>Block Cache</title>
        
                <para>HBase provides three different BlockCache implementations: the default onheap
                  LruBlockCache, BucketCache, and SlabCache, which are both (usually) offheap. This section
                  discusses benefits and drawbacks of each implementation, how to choose the appropriate
                  option, and configuration options for each.</para>
        
              <note><title>Block Cache Reporting: UI</title>
              <para>See the RegionServer UI for detail on caching deploy.  Since HBase-0.98.4, the
                  Block Cache detail has been significantly extended showing configurations,
                  sizings, current usage, and even detail on block counts and types.</para>
          </note>
        
                <section>
        
                  <title>Cache Choices</title>
                  <para><classname>LruBlockCache</classname> is the original implementation, and is
                      entirely within the Java heap. <classname>BucketCache</classname> is mainly
                      intended for keeping blockcache data offheap, although BucketCache can also
                      keep data onheap and serve from a file-backed cache. There is also an older
                      offheap BlockCache, called SlabCache that has since been deprecated and
                      removed in HBase 1.0.
                  </para>
        

        At least the first reference should probably go.

        Show
        Sean Busbey added a comment - If we're removing the SlabCache from the book, there are a couple of additional references: book.xml: <section xml:id= "block.cache" > <title>Block Cache</title> <para>HBase provides three different BlockCache implementations: the default onheap LruBlockCache, BucketCache, and SlabCache, which are both (usually) offheap. This section discusses benefits and drawbacks of each implementation, how to choose the appropriate option, and configuration options for each.</para> <note><title>Block Cache Reporting: UI</title> <para>See the RegionServer UI for detail on caching deploy. Since HBase-0.98.4, the Block Cache detail has been significantly extended showing configurations, sizings, current usage, and even detail on block counts and types.</para> </note> <section> <title>Cache Choices</title> <para><classname>LruBlockCache</classname> is the original implementation, and is entirely within the Java heap. <classname>BucketCache</classname> is mainly intended for keeping blockcache data offheap, although BucketCache can also keep data onheap and serve from a file-backed cache. There is also an older offheap BlockCache, called SlabCache that has since been deprecated and removed in HBase 1.0. </para> At least the first reference should probably go.
        Hide
        Jonathan Hsieh added a comment -

        +1

        Show
        Jonathan Hsieh added a comment - +1
        Hide
        Nicolas Liochon added a comment -

        +1, I don't find it anywhere when I apply the patch now

        Show
        Nicolas Liochon added a comment - +1, I don't find it anywhere when I apply the patch now
        Hide
        Anoop Sam John added a comment -

        Looks like we had a section for SlabCache in book. In this patch removing that section fully. Also removed section from upgrading.xml.

        Show
        Anoop Sam John added a comment - Looks like we had a section for SlabCache in book. In this patch removing that section fully. Also removed section from upgrading.xml.
        Hide
        Nicolas Liochon added a comment -

        I find the entry in book.xml and upgrading.xml but may be it's generated from the config file?

        Show
        Nicolas Liochon added a comment - I find the entry in book.xml and upgrading.xml but may be it's generated from the config file?
        Hide
        Matteo Bertozzi added a comment -

        +1

        Show
        Matteo Bertozzi added a comment - +1
        Hide
        Anoop Sam John added a comment -

        Also removed unused CacheConfig#DEFAULT_BUCKET_CACHE_COMBINED_PERCENTAGE

        Show
        Anoop Sam John added a comment - Also removed unused CacheConfig#DEFAULT_BUCKET_CACHE_COMBINED_PERCENTAGE

          People

          • Assignee:
            Anoop Sam John
            Reporter:
            Anoop Sam John
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development