HBase
  1. HBase
  2. HBASE-11687

No need to abort on postOpenDeployTasks exception if region opening is cancelled

    Details

    • Hadoop Flags:
      Reviewed

      Description

      With ZK-less region assignment, if region opening is in postOpenDeployTasks step and the opening is cancelled, the region server will abort because it can't report the transition to the master. We should cancel postOpenDeployTasks instead. At least, there is no need to abort.

        Issue Links

          Activity

          Hide
          Jimmy Xiang added a comment -

          Added a patch that aborts the rs only if the region is still opening.

          Show
          Jimmy Xiang added a comment - Added a patch that aborts the rs only if the region is still opening.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12661331/hbase-11687.patch
          against trunk revision .
          ATTACHMENT ID: 12661331

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s):

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12661331/hbase-11687.patch against trunk revision . ATTACHMENT ID: 12661331 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10406//console This message is automatically generated.
          Hide
          Matteo Bertozzi added a comment -

          +1

          Show
          Matteo Bertozzi added a comment - +1
          Hide
          Jimmy Xiang added a comment -

          Integrated into branch 1 and master. Thanks Matteo for the review.

          Show
          Jimmy Xiang added a comment - Integrated into branch 1 and master. Thanks Matteo for the review.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5398 (See https://builds.apache.org/job/HBase-TRUNK/5398/)
          HBASE-11687 No need to abort on postOpenDeployTasks exception if region opening is cancelled (jxiang: rev 4ed32bd77eb17ee5ca674b37aeb097741590cad0)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5398 (See https://builds.apache.org/job/HBase-TRUNK/5398/ ) HBASE-11687 No need to abort on postOpenDeployTasks exception if region opening is cancelled (jxiang: rev 4ed32bd77eb17ee5ca674b37aeb097741590cad0) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #102 (See https://builds.apache.org/job/HBase-1.0/102/)
          HBASE-11687 No need to abort on postOpenDeployTasks exception if region opening is cancelled (jxiang: rev ce6c2040786580f448f730313119b8feaffbd8bc)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-1.0 #102 (See https://builds.apache.org/job/HBase-1.0/102/ ) HBASE-11687 No need to abort on postOpenDeployTasks exception if region opening is cancelled (jxiang: rev ce6c2040786580f448f730313119b8feaffbd8bc) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
          Hide
          Andrew Purtell added a comment -

          Pushed to 0.98 as part of HBASE-11546

          Show
          Andrew Purtell added a comment - Pushed to 0.98 as part of HBASE-11546
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              Jimmy Xiang
              Reporter:
              Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development